Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts in editor background on macOS #75171

Closed
atomiks opened this issue Jun 10, 2019 · 4 comments
Closed

Artifacts in editor background on macOS #75171

atomiks opened this issue Jun 10, 2019 · 4 comments
Assignees
Labels
electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@atomiks
Copy link

atomiks commented Jun 10, 2019

  • VSCode Version: 1.35.0 (It started in 1.31.0)
  • OS Version: macOS 10.14.4

Steps to Reproduce:

  1. Change the current theme's editor.background to #212337
  2. Notice artifacts in the background

See right side of the editor background in this screenshot (not sidebar, to the left of the sidebar the colors are darker compared to the background color behind the code).

image

I mentioned this already here #68001 (comment)

But I stayed on 1.30.2 and forgot about it. Now I've updated to the latest version and it's still not fixed. However, I'm pretty sure the Electron 4.x upgrade next month fixes this from what I tested. It's just really weird how only colors right around the HSL values of this specific background color causes the artifacts...

Okay so weirdly enough, only colors right around the editor.background color I chose for this theme causes the artifact problem. If you change any theme's background color to this theme's exact background color, the problem occurs.

For now, you can change editor.background to a different color. e.g. Palenight's "editor.background": "#292D3E"

If I try to just move the color picker a few pixels from this theme's current background color, it's not enough to fix it. It's like a whole vicinity of colors around it that is buggy.

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Jun 10, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the themes Color theme issues label Jun 10, 2019
@bpasero
Copy link
Member

bpasero commented Jun 10, 2019

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@bpasero bpasero added info-needed Issue requires more information from poster and removed themes Color theme issues labels Jun 10, 2019
@atomiks
Copy link
Author

atomiks commented Jun 11, 2019

Yes it's fixed, I'm guessing it has something to do with the color profile.

Is that release version out stable in early July? My color theme has this artifact problem and it can't be fixed for the current versions :s

@bpasero bpasero added fixed-in-electron-4.0.x electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed info-needed Issue requires more information from poster labels Jun 11, 2019
@bpasero
Copy link
Member

bpasero commented Jul 1, 2019

We will ship with Electron 4 with our upcoming release 1.36 this week. As such I am closing this issue. To benefit from the update already today, consider to use our insiders version: https://code.visualstudio.com/insiders/

@bpasero bpasero closed this as completed Jul 1, 2019
@bpasero bpasero added this to the June 2019 milestone Jul 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants