Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

font rendering issue after upgrading to electron 4.x #75380

Closed
yisiqi opened this issue Jun 13, 2019 · 3 comments
Closed

font rendering issue after upgrading to electron 4.x #75380

yisiqi opened this issue Jun 13, 2019 · 3 comments
Assignees
@bpasero @deepak1556
Labels
*duplicate Issue identified as a duplicate of another issue(s) electron Issues and items related to Electron font-rendering Font rendering issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
Electron

Comments

@yisiqi
Copy link

yisiqi commented Jun 13, 2019

  • VSCode Version: 1.36.0 - Insiders (2019-06-12T19:40:38.592Z)
  • OS Version: macOS mojave 10.14.5

The font is rendered too thin on the retina display. The previous solution didn't work. Significantly different from the stable version rendering

I thought this problem will be solved after upgrading to electron 4.x.

屏幕快照 2019-06-13 上午9 26 52

屏幕快照 2019-06-13 上午9 26 55

Does this issue occur when all extensions are disabled?: Yes
@vscodebot vscodebot bot added the editor-find Editor find operations label Jun 13, 2019
@Tyriar Tyriar removed the editor-find Editor find operations label Jun 13, 2019
@Tyriar Tyriar added the electron Issues and items related to Electron label Jun 13, 2019
@bpasero bpasero added electron-4.0.x-update font-rendering Font rendering issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jun 14, 2019
@bpasero
Copy link
Member

bpasero commented Jun 14, 2019

Possibly related: electron/electron#15007

@bpasero bpasero mentioned this issue Jun 15, 2019
Closed
@deepak1556
Copy link
Contributor

I am merging this into #59887 , @yisiqi can you comment on that issue with data from #59887 (comment) . Thanks!

@deepak1556 deepak1556 reopened this Jul 1, 2019
@deepak1556 deepak1556 added this to Unsorted Issues in Electron Jul 8, 2019
@deepak1556 deepak1556 added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 9, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 9, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 9, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@deepak1556 deepak1556

Labels
*duplicate Issue identified as a duplicate of another issue(s) electron Issues and items related to Electron font-rendering Font rendering issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
No open projects
Electron
Unsorted Issues
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bpasero @deepak1556 @yisiqi @Tyriar