Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron 7: going full screen makes the whole screen flickr #86256

Closed
isidorn opened this issue Dec 4, 2019 · 8 comments
Closed

Electron 7: going full screen makes the whole screen flickr #86256

isidorn opened this issue Dec 4, 2019 · 8 comments
Assignees
@deepak1556
Labels
confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron macos Issues with VS Code on MAC/OS X workbench-zen Full screen 'Zen' view issues
Milestone
February 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 4, 2019 •
edited

Refs: #85994

Catalina, Electron 7.1.3

  1. Make sure to have "window.nativeFullScreen": true
  2. Go to full screen -> the transition is not smooth, there is a flash of black screen for a moment

The full screen transition for my current chrome 78 is much more smoother
@deepak1556 deepak1556 added confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron macos Issues with VS Code on MAC/OS X workbench-zen Full screen 'Zen' view issues electron-7-update labels Dec 6, 2019
@bpasero
Copy link
Member

bpasero commented Jan 10, 2020

@isidorn I cannot reproduce this with today's insider build (which comes with E7). Can you try again?

@bpasero bpasero added the info-needed Issue requires more information from poster label Jan 10, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Jan 10, 2020

I can reproduce on my machine.

@bpasero
Copy link
Member

bpasero commented Jan 10, 2020 •
edited

Oh yeah, I see it too. I was accidentally trying with the simple fullscreen. I see a brief flash of white that does not seem to happen with Electron 6.

@bpasero bpasero removed the info-needed Issue requires more information from poster label Jan 10, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Jan 10, 2020

Exactly!

@Al-Ferguson
Copy link

Could this be Electron #21750? Which was fixed in Electron 7.1.9.

@bpasero
Copy link
Member

bpasero commented Jan 15, 2020

Yeah, we still have not yet updated, but maybe @isidorn could try this running out of sources by changing our .yarnrc to 7.1.9.

@bpasero bpasero added this to the February 2020 milestone Jan 24, 2020
@bpasero
Copy link
Member

bpasero commented Feb 12, 2020

@isidorn does this still happen in latest insider for you?

@isidorn
Copy link
Contributor Author

isidorn commented Feb 12, 2020

No. Now it behaves fine. Thus closing.

@isidorn isidorn closed this as completed Feb 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron macos Issues with VS Code on MAC/OS X workbench-zen Full screen 'Zen' view issues
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
4 participants
@bpasero @deepak1556 @isidorn @Al-Ferguson