Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron 7: macOS zip does not seem proper #86462

Closed
bpasero opened this issue Dec 6, 2019 · 2 comments
Closed

Electron 7: macOS zip does not seem proper #86462

bpasero opened this issue Dec 6, 2019 · 2 comments
Assignees
@deepak1556
Labels
confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron upstream-issue-fixed The underlying upstream issue has been fixed
Milestone
February 2020

Comments

@bpasero
Copy link
Member

bpasero commented Dec 6, 2019

The contents appear as:

image

That extra file seems it should be removed.
@deepak1556 deepak1556 added confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Dec 6, 2019
@deepak1556
Copy link
Contributor

electron/electron#21447

@deepak1556 deepak1556 added upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed and removed upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels Dec 9, 2019
@bpasero
Copy link
Member Author

bpasero commented Jan 10, 2020

Seems fixed now.

@bpasero bpasero closed this as completed Jan 10, 2020
@bpasero bpasero added this to the January 2020 milestone Jan 10, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron upstream-issue-fixed The underlying upstream issue has been fixed
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
2 participants
@bpasero @deepak1556