Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 7: restoring minimised windows shows blank for a brief moment #89010

Closed
bpasero opened this issue Jan 21, 2020 · 2 comments
Closed

Electron 7: restoring minimised windows shows blank for a brief moment #89010

bpasero opened this issue Jan 21, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron macos Issues with VS Code on MAC/OS X regression Something that used to work is now broken upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jan 21, 2020

Steps to Reproduce:

  1. macOS
  2. minimize window using Cmd+M
  3. restore by clicking on dock

=> 馃悰 the code window appears empty for a brief moment until it restores

Reproduces in other Electron apps like fiddle for me too. Filed as electron/electron#21844

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) macos Issues with VS Code on MAC/OS X electron Issues and items related to Electron regression Something that used to work is now broken upstream-issue-linked This is an upstream issue that has been reported upstream electron-7-update labels Jan 21, 2020
@bpasero
Copy link
Member Author

bpasero commented Jan 21, 2020

We need to verify this with latest Electron 7.1.9 according to electron/electron#21844

@bpasero bpasero added the upstream-issue-fixed The underlying upstream issue has been fixed label Jan 21, 2020
@bpasero bpasero added this to the January 2020 milestone Jan 21, 2020
@bpasero
Copy link
Member Author

bpasero commented Jan 22, 2020

Confirmed, this seems fixed with Electron 7.1.9

@bpasero bpasero modified the milestones: January 2020, February 2020 Jan 24, 2020
@bpasero bpasero closed this as completed Feb 5, 2020
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Feb 5, 2020
@bpasero bpasero added the verified Verification succeeded label Feb 25, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron macos Issues with VS Code on MAC/OS X regression Something that used to work is now broken upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants