Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing when reloading the window with fresh --user-data-dir #91509

Closed
roblourens opened this issue Feb 26, 2020 · 1 comment
Closed

Crashing when reloading the window with fresh --user-data-dir #91509

roblourens opened this issue Feb 26, 2020 · 1 comment
Assignees
Labels
confirmation-pending freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues macos Issues with VS Code on MAC/OS X zoom VS Code window zoom issues

Comments

@roblourens
Copy link
Member

  • Start vscode with a clean --user-data-dir
  • It has crashed a few times when reloading the window

Discussed offline, this is the symbolified stack

Thread 0 Crashed:: CrBrowserMain  Dispatch queue: com.apple.main-thread
v8::Object::CreateDataProperty(v8::Local<v8::Context>, v8::Local<v8::Name>, v8::Local<v8::Value>) (in Electron Framework) (api.cc:295)
electron::WebContentsZoomController::SetZoomFactorOnNavigationIfNeeded(GURL const&) (in Electron Framework) (web_contents_zoom_controller.cc:258)
v8::Object::CreateDataProperty(v8::Local<v8::Context>, v8::Local<v8::Name>, v8::Local<v8::Value>) (in Electron Framework) (api.cc:4021)
v8::internal::Stats_Runtime_InstantiateAsmJs(int, unsigned long*, v8::internal::Isolate*) (in Electron Framework) (counters.h:1396)
v8::internal::Bignum::PlusCompare(v8::internal::Bignum const&, v8::internal::Bignum const&, v8::internal::Bignum const&) (in Electron Framework) (bignum.cc:601)
v8::internal::Stats_Runtime_FatalProcessOutOfMemoryInAllocateRaw(int, unsigned long*, v8::internal::Isolate*) (in Electron Framework) (runtime-internal.cc:45)
v8::internal::CallDescriptors::InitializeOncePerProcess() (in Electron Framework) (interface-descriptors.cc:80)
v8::internal::CallDescriptors::InitializeOncePerProcess() (in Electron Framework) (interface-descriptors.cc:80)
v8::internal::Builtin_Impl_BigIntAsUintN(v8::internal::BuiltinArguments, v8::internal::Isolate*) (in Electron Framework) (builtins-bigint.cc:52)
v8::internal::Compiler::FinalizeOptimizedCompilationJob(v8::internal::OptimizedCompilationJob*, v8::internal::Isolate*) (in Electron Framework) (compiler.cc:2284)
v8::internal::CallDescriptors::InitializeOncePerProcess() (in Electron Framework) (interface-descriptors.cc:80)
v8::internal::Builtin_Impl_Stats_IsPromise(int, unsigned long*, v8::internal::Isolate*) (in Electron Framework) (counters.h:1187)
v8::internal::CallDescriptors::InitializeOncePerProcess() (in Electron Framework) (interface-descriptors.cc:80)
v8::internal::Builtin_Impl_CallSitePrototypeGetScriptNameOrSourceURL(v8::internal::BuiltinArguments, v8::internal::Isolate*) (in Electron Framework) (builtins-callsite.cc:127)
v8::internal::DateParser::DateStringTokenizer<unsigned short const>::Scan() (in Electron Framework) (dateparser-inl.h:216)
v8::internal::Builtin_Impl_Stats_LocalePrototypeMinimize(int, unsigned long*, v8::internal::Isolate*) (in Electron Framework) (builtins-intl.cc:662)
v8::internal::Builtin_Impl_LocaleConstructor(v8::internal::BuiltinArguments, v8::internal::Isolate*) (in Electron Framework) (handles-inl.h:88)
electron::api::WebContents::DidStartNavigation(content::NavigationHandle*) (in Electron Framework) (atom_api_web_contents.cc:1096)
bool mate::EventEmitter<electron::api::WebContents>::EmitWithEvent<int&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&, GURL&, bool&, int&, int&>(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, v8::Local<v8::Object>, int&&&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&&, GURL&&&, bool&&&, int&&&, int&&&) (in Electron Framework) (event_emitter.h:107)
v8::internal::compiler::NativeContextData::Serialize(v8::internal::compiler::JSHeapBroker*) (in Electron Framework) (js-heap-broker.cc:1936)
v8::internal::compiler::JSCallReducer::LoadReceiverElementsKind(v8::internal::compiler::Node*, v8::internal::compiler::Node**, v8::internal::compiler::Node**) (in Electron Framework) (js-call-reducer.cc:4346)
v8::internal::compiler::JSCallReducer::ReducePromiseConstructor(v8::internal::compiler::Node*) (in Electron Framework) (js-operator.cc:842)
content::ServiceWorkerContextWrapper::OnRegistrationCompleted(long long, GURL const&) (in Electron Framework) (service_worker_context_wrapper.cc:351)
content::ServiceVideoCaptureDeviceLauncher::LaunchDeviceAsync(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, blink::mojom::MediaStreamType, media::VideoCaptureParams const&, base::WeakPtr<media::VideoFrameReceiver>, base::OnceCallback<void ()>, content::VideoCaptureDeviceLauncher::Callbacks*, base::OnceCallback<void ()>) (in Electron Framework) (service_video_capture_device_launcher.cc:154)
content::ServiceVideoCaptureDeviceLauncher::LaunchDeviceAsync(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, blink::mojom::MediaStreamType, media::VideoCaptureParams const&, base::WeakPtr<media::VideoFrameReceiver>, base::OnceCallback<void ()>, content::VideoCaptureDeviceLauncher::Callbacks*, base::OnceCallback<void ()>) (in Electron Framework) (service_video_capture_device_launcher.cc:154)
content::MediaStreamUIProxy::Core::RequestAccess(std::__1::unique_ptr<content::MediaStreamRequest, std::__1::default_delete<content::MediaStreamRequest> >) (in Electron Framework) (media_stream_ui_proxy.cc:114)
content::ServiceVideoCaptureDeviceLauncher::LaunchDeviceAsync(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, blink::mojom::MediaStreamType, media::VideoCaptureParams const&, base::WeakPtr<media::VideoFrameReceiver>, base::OnceCallback<void ()>, content::VideoCaptureDeviceLauncher::Callbacks*, base::OnceCallback<void ()>) (in Electron Framework) (service_video_capture_device_launcher.cc:154)
content::ServiceVideoCaptureDeviceLauncher::LaunchDeviceAsync(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, blink::mojom::MediaStreamType, media::VideoCaptureParams const&, base::WeakPtr<media::VideoFrameReceiver>, base::OnceCallback<void ()>, content::VideoCaptureDeviceLauncher::Callbacks*, base::OnceCallback<void ()>) (in Electron Framework) (service_video_capture_device_launcher.cc:154)
content::ServiceVideoCaptureDeviceLauncher::LaunchDeviceAsync(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, blink::mojom::MediaStreamType, media::VideoCaptureParams const&, base::WeakPtr<media::VideoFrameReceiver>, base::OnceCallback<void ()>, content::VideoCaptureDeviceLauncher::Callbacks*, base::OnceCallback<void ()>) (in Electron Framework) (service_video_capture_device_launcher.cc:154)
content::RenderProcessHostImpl::~RenderProcessHostImpl() (in Electron Framework) (render_process_host_impl.cc:1572)
content::RenderWidgetHostInputEventRouter::FindViewFromFrameSinkId(viz::FrameSinkId const&) const (in Electron Framework) (render_widget_host_input_event_router.cc:1730)
0x01ead3fa (in Electron Framework)
content::RenderFrameAudioInputStreamFactory::Core::Core(mojo::InterfaceRequest<content::mojom::RendererAudioInputStreamFactory>, content::MediaStreamManager*, content::RenderFrameHost*) (in Electron Framework) (render_frame_audio_input_stream_factory.cc:198)
v8::internal::compiler::MachineOperatorGlobalCache::StorekWord64NoWriteBarrierOperator::~StorekWord64NoWriteBarrierOperator() (in Electron Framework) (machine-operator.cc:661)
v8::internal::compiler::MachineOperatorGlobalCache::ProtectedStorekCompressedSignedOperator::~ProtectedStorekCompressedSignedOperator() (in Electron Framework) (machine-operator.cc:661)
v8::internal::MicrotaskQueue::RunMicrotasks(v8::internal::Isolate*) + 489
node::InternalCallbackScope::Close() + 260
content::DropDataBuilder::Build(blink::WebDragData const&) (in Electron Framework) (vector:0)
node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) + 161
mate::internal::Dispatcher<bool (electron::api::KeyWeakMap<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, int> >*, std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, int> const&)>::DispatchToCallback(v8::FunctionCallbackInfo<v8::Value> const&) (in Electron Framework) (function_template.h:244)
bool mate::EventEmitter<electron::api::WebContents>::EmitWithEvent<content::NativeWebKeyboardEvent const&>(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, v8::Local<v8::Object>, content::NativeWebKeyboardEvent const&&&) (in Electron Framework) (event_emitter.h:115)
bool mate::EventEmitter<electron::api::WebContents>::EmitWithSender<content::NativeWebKeyboardEvent const&>(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, content::RenderFrameHost*, base::Optional<base::OnceCallback<void (base::Value)> >, content::NativeWebKeyboardEvent const&&&) (in Electron Framework) (event_emitter.h:87)
non-virtual thunk to electron::api::WebContents::PreHandleKeyboardEvent(content::WebContents*, content::NativeWebKeyboardEvent const&) (in Electron Framework) (atom_api_web_contents.cc:0)
electron::api::WebContents::ContentsZoomChange(bool) (in Electron Framework) (atom_api_web_contents.cc:724)
service_manager::ManifestBuilder& service_manager::ManifestBuilder::ExposeCapability<device::mojom::SensorProvider>(char const*, service_manager::Manifest::InterfaceList<device::mojom::SensorProvider>) (in Electron Framework) (manifest_builder.h:60)
icu_64::TransliteratorIDParser::parseSingleID(icu_64::UnicodeString const&, int&, int, UErrorCode&) (in Electron Framework) (unistr.h:4625)
icu_64::TimeZoneFormat::parse(UTimeZoneFormatStyle, icu_64::UnicodeString const&, icu_64::ParsePosition&, int, UTimeZoneFormatTimeType*) const (in Electron Framework) (tzfmt.cpp:915)
icu_64::TimeZoneFormat::formatSpecific(icu_64::TimeZone const&, UTimeZoneNameType, UTimeZoneNameType, double, icu_64::UnicodeString&, UTimeZoneFormatTimeType*) const (in Electron Framework) (tzfmt.cpp:1365)
icu_64::TransliteratorAlias::create(UParseError&, UErrorCode&) (in Electron Framework) (transreg.cpp:122)
icu_64::TransliteratorSpec::reset() (in Electron Framework) (transreg.cpp:314)
i18n_cleanup() (in Electron Framework) (ucln_in.cpp:39)
void node::inspector::protocol::DictionaryValue::set<node::inspector::protocol::Value>(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::unique_ptr<node::inspector::protocol::Value, std::__1::default_delete<node::inspector::protocol::Value> >&) (in Electron Framework) (Protocol.h:273)
proxy_resolver::ProxyResolverFactoryImpl::CreateResolver(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, mojo::PendingReceiver<proxy_resolver::mojom::ProxyResolver>, mojo::PendingRemote<proxy_resolver::mojom::ProxyResolverFactoryRequestClient>) (in Electron Framework) (proxy_resolver_factory_impl.cc:114)
proxy_resolver::MojoProxyResolverV8TracingBindings<proxy_resolver::mojom::ProxyResolverFactoryRequestClient>::Alert(std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&) (in Electron Framework) (mojo_proxy_resolver_v8_tracing_bindings.h:45)
(anonymous namespace)::itanium_demangle::AbstractManglingParser<(anonymous namespace)::itanium_demangle::ManglingParser<(anonymous namespace)::DefaultAllocator>, (anonymous namespace)::DefaultAllocator>::parseFunctionType() (in Electron Framework) (ItaniumDemangle.h:0)
content::SiteIsolationPolicy::GetIsolatedOriginsFromFieldTrial() (in Electron Framework) (site_isolation_policy.cc:146)
(anonymous namespace)::itanium_demangle::FunctionEncoding::printRight((anonymous namespace)::itanium_demangle::OutputStream&) const (in Electron Framework) (ItaniumDemangle.h:811)
__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
__CFRunLoopDoSource0 + 108
__CFRunLoopDoSources0 + 195
__CFRunLoopRun + 1189
CFRunLoopRunSpecific + 455
RunCurrentEventLoopInMode + 292
ReceiveNextEventCommon + 603
_BlockUntilNextEventMatchingListInModeWithFilter + 64
_DPSNextEvent + 1135
-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1361
-[NSApplication run] + 699
0x0230985c (in Electron Framework)
(anonymous namespace)::itanium_demangle::TemplateArgumentPack::printLeft((anonymous namespace)::itanium_demangle::OutputStream&) const (in Electron Framework) (Utility.h:85)
mojo::ReceiverSetBase<mojo::Receiver<proxy_resolver::mojom::ProxyResolver, mojo::UniquePtrImplRefTraits<proxy_resolver::mojom::ProxyResolver, std::__1::default_delete<proxy_resolver::mojom::ProxyResolver> > >, void>::Entry::Entry(std::__1::unique_ptr<proxy_resolver::mojom::ProxyResolver, std::__1::default_delete<proxy_resolver::mojom::ProxyResolver> >, mojo::PendingReceiver<proxy_resolver::mojom::ProxyResolver>, mojo::ReceiverSetBase<mojo::Receiver<proxy_resolver::mojom::ProxyResolver, mojo::UniquePtrImplRefTraits<proxy_resolver::mojom::ProxyResolver, std::__1::default_delete<proxy_resolver::mojom::ProxyResolver> > >, void>*, unsigned long, bool, scoped_refptr<base::SequencedTaskRunner>) (in Electron Framework) (receiver_set.h:284)
void std::__1::vector<scoped_refptr<url_matcher::URLMatcherConditionSet>, std::__1::allocator<scoped_refptr<url_matcher::URLMatcherConditionSet> > >::__push_back_slow_path<scoped_refptr<url_matcher::URLMatcherConditionSet> >(scoped_refptr<url_matcher::URLMatcherConditionSet>&&) (in Electron Framework) (vector:1627)
v8::Float64Array::CheckCast(v8::Value*) (in Electron Framework) (api.cc:3795)
v8::Object::Set(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>) (in Electron Framework) (api.cc:298)
v8::Value::NumberValue(v8::Local<v8::Context>) const (in Electron Framework) (api.cc:3859)
viz::mojom::FrameSinkVideoCapturerStubDispatch::Accept(viz::mojom::FrameSinkVideoCapturer*, mojo::Message*) (in Electron Framework) (frame_sink_video_capture.mojom.cc:0)
viz::mojom::FrameSinkVideoCapturerProxy::Start(mojo::InterfacePtr<viz::mojom::FrameSinkVideoConsumer>) (in Electron Framework) (frame_sink_video_capture.mojom.cc:801)
sh::InitExtensionBehavior(ShBuiltInResources const&, std::__1::map<sh::TExtension, sh::TBehavior, std::__1::less<sh::TExtension>, std::__1::allocator<std::__1::pair<sh::TExtension const, sh::TBehavior> > >&) (in Electron Framework) (Initialize.cpp:38)
viz::mojom::FrameSinkVideoConsumerStubDispatch::Accept(viz::mojom::FrameSinkVideoConsumer*, mojo::Message*) (in Electron Framework) (frame_sink_video_capture.mojom.cc:428)
AtomMain + 84
0x000009e0 (in Electron Framework)

@deepak1556 deepak1556 added confirmation-pending freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues zoom VS Code window zoom issues macos Issues with VS Code on MAC/OS X labels Mar 11, 2020
@deepak1556
Copy link
Contributor

This should be fixed by #102195, can reopen if the issue still exists.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
confirmation-pending freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues macos Issues with VS Code on MAC/OS X zoom VS Code window zoom issues
Projects
None yet
Development

No branches or pull requests

2 participants