Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #4610 to 17.7.0? #4627

Closed
JamesNK opened this issue Jul 30, 2023 · 2 comments
Closed

Backport #4610 to 17.7.0? #4627

JamesNK opened this issue Jul 30, 2023 · 2 comments

Comments

@JamesNK
Copy link
Member

JamesNK commented Jul 30, 2023 •
edited

#4610 fixes a regression in .NET 8: #4549

However, it doesn't look like the fix is in 17.7.0, which is what .NET 8 uses. Should the changes be backported to 17.7.0 to fix the .NET 8 regression?
@nohwnd
Copy link
Member

nohwnd commented Jul 31, 2023

We should probably move to inserting 17.8 into .NET 8. @cvpoienaru please have a look.

@nohwnd
Copy link
Member

nohwnd commented Aug 2, 2023

We started inserting 17.8 into .NET 8.

Backported to 17.7 in #4632 which won't affect net8, but will affect net7.0.4xx.

@nohwnd nohwnd closed this as completed Aug 2, 2023
@nohwnd nohwnd mentioned this issue Aug 16, 2023
Closed
@nohwnd nohwnd mentioned this issue Aug 24, 2023
Closed
@austindrenski austindrenski mentioned this issue Aug 29, 2023
Closed
shinji-san added a commit to shinji-san/SecretSharingDotNet that referenced this issue Sep 9, 2023
@shinji-san
SecretSharingDotNetTest.csproj: TargetFrameworks w/o .NET FX
86fa87f 
Workaround for the following issues with the Microsoft.TestPlatform.ObjectModel package:
- microsoft/vstest#4549
- microsoft/vstest#4671
- microsoft/vstest#4627

Resolves: No entry
This was referenced Sep 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesNK @nohwnd