Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for long running operations #148

Open
RobinKamps opened this issue Jan 4, 2023 · 6 comments
Open

add support for long running operations #148

RobinKamps opened this issue Jan 4, 2023 · 6 comments
Assignees
Labels
blocked work cannot start on this because we're blocked by an upstream dependency enhancement New feature or request

Comments

@RobinKamps
Copy link

  1. the golang examples under https://learn.microsoft.com/en-us/graph/api/team-post?view=graph-rest-1.0&tabs=go are missing the member odata type, e.g.
odataType := "#microsoft.graph.aadUserConversationMember"
member.SetOdataType(&odataType)
  1. if result, err := graphClient.Teams().Post(context.Background(), requestBody, nil) is called, the result is always nil, not Teamable or at least containing the new teamID as documented (but the team is successfully created).
@ghost ghost added the needs triage 🔍 label Jan 4, 2023
@baywet baywet added needs attention 👋 bug Something isn't working documentation Improvements or additions to documentation and removed needs triage 🔍 labels Jan 4, 2023
@baywet baywet assigned darrelmiller and unassigned rkodev Jan 4, 2023
@baywet baywet added enhancement New feature or request and removed bug Something isn't working documentation Improvements or additions to documentation needs attention 👋 labels Jan 4, 2023
@baywet
Copy link
Member

baywet commented Jan 4, 2023

Hi @RobinKamps
Thanks for using the Go SDK and for reaching out.
Could you create a separate issue for the missing odata type in the snippet please?
As for the Id always being null the redirect handler only follows 300 class status codes, and it's a design choice for the time being. @darrelmiller do you think we should expand that to 200 class as well?

@RobinKamps
Copy link
Author

thank you for the fast reply. i created a pull request for the missing odata type in the documentation repo.

@baywet
Copy link
Member

baywet commented Jan 4, 2023

unfortunately those snippets are automatically generated. And your change will get overwritten with the next generation. We need to fix the generation logic.
We do accept pull requests on the generation logic, the easiest is probably to add a new unit test with the http snippet and start from there if you feel like fixing the snippet generation.

@RobinKamps
Copy link
Author

Thank you for the reply - i opened separate issues for the documentation errors.

@RobinKamps
Copy link
Author

please add a 202 response for the async request, so that users of the go sdk can do the polling:
https://learn.microsoft.com/en-us/graph/api/resources/teamsasyncoperation?view=graph-rest-1.0
(of course an integrated polling mechanism where callback funcs for success / errors/ timeouts can be provided, would be nice, too)

@baywet
Copy link
Member

baywet commented Jan 4, 2023

Thanks for the comment, this is something that's currently not implemented across all of the SDKs and needs to be implemented manually by SDK users.
I've added an issue for our architect to work on a technical specification so our team can implement it across languages.
I'll also transfer this issue to the core repository shortly, where we implement those cross-cutting concerns.

@ghost ghost added the needs triage 🔍 label Jan 4, 2023
@baywet baywet transferred this issue from microsoftgraph/msgraph-sdk-go Jan 4, 2023
@baywet baywet changed the title create team result is always nil add support for long running operations Jan 4, 2023
@baywet baywet added blocked work cannot start on this because we're blocked by an upstream dependency and removed needs triage 🔍 labels Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked work cannot start on this because we're blocked by an upstream dependency enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants