Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @fastify/busboy instead of outdated busboy #1145

Closed
jonasgeiler opened this issue Nov 28, 2023 · 2 comments
Closed

Use @fastify/busboy instead of outdated busboy #1145

jonasgeiler opened this issue Nov 28, 2023 · 2 comments

Comments

@jonasgeiler
Copy link

Is your feature request related to a problem? Please describe.
Not really a problem but the busboy fork by the Fastify team, @fastify/busboy, contains a few bug fixes and performance improvements and is actively maintained.

Describe the solution you'd like
I'm pretty sure all you need to do is replace busboy with @fastify/busboy in the http-multipart-body-parser middleware

Describe alternatives you've considered
Not really applicable. There are of course numerous busboy forks out there but the one by the Fastify team seems to be the most popular and active one.

Additional context
I am not being paid by the Fastify team for this :D

@willfarrell
Copy link
Member

Awesome, interested in putting a PR together?

mergify bot pushed a commit to SvenKirschbaum/aws-utils that referenced this issue Dec 3, 2023
[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@middy/core](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2fcore/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fcore/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fcore/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fcore/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fcore/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/error-logger](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2ferror-logger/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2ferror-logger/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2ferror-logger/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2ferror-logger/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2ferror-logger/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-error-handler](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2fhttp-error-handler/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-error-handler/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-error-handler/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-error-handler/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-error-handler/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-header-normalizer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2fhttp-header-normalizer/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-header-normalizer/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-header-normalizer/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-header-normalizer/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-header-normalizer/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-response-serializer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2fhttp-response-serializer/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-response-serializer/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-response-serializer/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-response-serializer/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-response-serializer/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>middyjs/middy (@&#8203;middy/core)</summary>

### [`v5.1.0`](https://togithub.com/middyjs/middy/releases/tag/5.1.0)

[Compare Source](https://togithub.com/middyjs/middy/compare/5.0.3...5.1.0)

##### What's Changed

-   feat: Add name property to MiddlewareObj typings by [@&#8203;daedal-knickerbockers](https://togithub.com/daedal-knickerbockers) in [middyjs/middy#1146
-   feat: replace `busboy` with updated fastify version [@&#8203;skayo](https://togithub.com/skayo) [middyjs/middy#1145

##### New Contributors

-   [@&#8203;daedal-knickerbockers](https://togithub.com/daedal-knickerbockers) made their first contribution in [middyjs/middy#1146

**Full Changelog**: middyjs/middy@5.0.3...5.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/aws-utils).
mergify bot pushed a commit to SvenKirschbaum/share.kirschbaum.cloud that referenced this issue Dec 10, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@middy/core](https://middy.js.org) ([source](https://togithub.com/middyjs/middy/tree/HEAD/packages/core)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2fcore/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fcore/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fcore/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fcore/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fcore/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/error-logger](https://middy.js.org) ([source](https://togithub.com/middyjs/middy/tree/HEAD/packages/error-logger)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2ferror-logger/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2ferror-logger/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2ferror-logger/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2ferror-logger/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2ferror-logger/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-content-negotiation](https://middy.js.org) ([source](https://togithub.com/middyjs/middy/tree/HEAD/packages/http-content-negotiation)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2fhttp-content-negotiation/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-content-negotiation/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-content-negotiation/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-content-negotiation/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-content-negotiation/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-error-handler](https://middy.js.org) ([source](https://togithub.com/middyjs/middy/tree/HEAD/packages/http-error-handler)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2fhttp-error-handler/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-error-handler/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-error-handler/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-error-handler/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-error-handler/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-header-normalizer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy/tree/HEAD/packages/http-header-normalizer)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2fhttp-header-normalizer/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-header-normalizer/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-header-normalizer/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-header-normalizer/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-header-normalizer/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-json-body-parser](https://middy.js.org) ([source](https://togithub.com/middyjs/middy/tree/HEAD/packages/http-json-body-parser)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2fhttp-json-body-parser/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-json-body-parser/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-json-body-parser/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-json-body-parser/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-json-body-parser/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-response-serializer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy/tree/HEAD/packages/http-response-serializer)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2fhttp-response-serializer/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-response-serializer/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-response-serializer/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-response-serializer/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-response-serializer/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/validator](https://middy.js.org) ([source](https://togithub.com/middyjs/middy/tree/HEAD/packages/validator)) | [`5.0.3` -> `5.1.0`](https://renovatebot.com/diffs/npm/@middy%2fvalidator/5.0.3/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fvalidator/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fvalidator/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fvalidator/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fvalidator/5.0.3/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>middyjs/middy (@&#8203;middy/core)</summary>

### [`v5.1.0`](https://togithub.com/middyjs/middy/releases/tag/5.1.0)

[Compare Source](https://togithub.com/middyjs/middy/compare/5.0.3...5.1.0)

##### What's Changed

-   feat: Add name property to MiddlewareObj typings by [@&#8203;daedal-knickerbockers](https://togithub.com/daedal-knickerbockers) in [middyjs/middy#1146
-   feat: replace `busboy` with updated fastify version [@&#8203;skayo](https://togithub.com/skayo) [middyjs/middy#1145

##### New Contributors

-   [@&#8203;daedal-knickerbockers](https://togithub.com/daedal-knickerbockers) made their first contribution in [middyjs/middy#1146

**Full Changelog**: middyjs/middy@5.0.3...5.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/share.kirschbaum.cloud).
@jonasgeiler
Copy link
Author

Awesome, interested in putting a PR together?

Totally missed you comment there, but I just saw you added it. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants