Framerate & Cine issues

[norman-ma]

In this code when we run the multiframe US, the viewportSpecificData object does not have a cine property and so the cine framerate remains the default of 24. viewportSpecificData does have a framerate property however.

OHIF-Viewers/extensions/cornerstone/src/ConnectedCornerstoneViewport.js

Line 41 in 1cc94f3

if (viewportSpecificData && viewportSpecificData.cine) {

if (viewportSpecificData && viewportSpecificData.cine) {
    const cine = viewportSpecificData.cine;

    isPlaying = cine.isPlaying === true;
    frameRate = cine.cineFrameRate || frameRate;
  }

[norman-ma]

This is where the FrameTime property is retireved and the framerate derived.

This is eventually added to the viewportSpecificData but not to a viewportSpecificData.cine object.

OHIF-Viewers/extensions/cornerstone/src/components/OHIFCornerstoneViewportOverlay.js

Line 63 in 78f1a7f

const cineModule = cornerstone.metaData.get('cineModule', imageId) || {};

const cineModule = cornerstone.metaData.get('cineModule', imageId) || {};
const { frameTime } = cineModule;
const frameRate = formatNumberPrecision(1000 / frameTime, 1);

[norman-ma]

This is the CINE_MODULE handler in the metaDataProvider. It only gets the frameTime.

OHIF-Viewers/platform/core/src/classes/MetadataProvider.js

Line 430 in 1d85f7a

case WADO_IMAGE_LOADER_TAGS.CINE_MODULE:

case WADO_IMAGE_LOADER_TAGS.CINE_MODULE:
        metadata = {
          frameTime: instance.FrameTime,
        };

        break;