New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite to lowdb #990

Open

3 tasks

mifi opened this issue Jan 20, 2022 · 0 comments

Labels

Owner

mifi commented Jan 20, 2022 •

edited

Benefits:

It's async so should yield better performance (electron-store is sync, so it blocks the js event loop)
It is atomic (no corrupted saves in case of crash/bug)
Guarantees order of writes to prevent race conditions

Caveats:
must catch errors when trying to write/read:

Tasks

blocked by Rewrite to ESM #995
replace project file save/load code

lossless-cut/src/edlStore.js

Line 80 in 97b5840

await fs.writeFile(savePath, JSON5.stringify(projectData, null, 2));
replace electron-store for settings storage too

mifi added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment