Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Upstream) [no-redeclare] error for declare namespace #81

Closed
despian opened this issue Jun 20, 2019 · 4 comments
Closed

(Upstream) [no-redeclare] error for declare namespace #81

despian opened this issue Jun 20, 2019 · 4 comments
Assignees

Comments

@despian
Copy link

despian commented Jun 20, 2019

Using the declaration merging feature of TypeScript causes the no-redeclare rule to be triggered.

E.g.

declare namespace Foo {
...
}
declare const Foo: Bar

I couldn't find a rule upstream in typescript-eslint. Maybe it needs to be fixed there first. I'll create an issue there too.

Edit:
Found an existing issue: typescript-eslint#60

Edit: upstream issue merged into typescript-eslint/typescript-eslint#1856

@mightyiam
Copy link
Owner

Thank you for following through to upstream. I would work around using comments. Closing here.

@despian
Copy link
Author

despian commented Jun 21, 2019

Yeah, I'm already using comments.

I'm guessing that the fix upstream will result in a new rule. Once available won't the standard rule need to be disabled and the new rule enabled in this project? Do you think it's worth keeping this issue open to keep track of that piece of work?

@mightyiam
Copy link
Owner

Sure, we could keep it open. I'll rename it.

@mightyiam mightyiam reopened this Jun 21, 2019
@mightyiam mightyiam changed the title Support for declaration merging (Upstream) [no-redeclare] error for declare namespace Jun 21, 2019
@mightyiam mightyiam self-assigned this Jun 10, 2020
@rostislav-simonik
Copy link
Collaborator

it seems to have been closed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants