Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: No such template 'custom_template' #451

Closed
arunpersaud opened this issue Feb 20, 2022 · 4 comments
Closed

Error: No such template 'custom_template' #451

arunpersaud opened this issue Feb 20, 2022 · 4 comments
Labels

Comments

@arunpersaud
Copy link

Hi

just trying to build the package for openSUSE and I'm getting

Error: No such template 'custom_template'

when running the tests. The tar-ball seems to have the custom_template directory missing that's in the test directory, is that the issue?

@miguelgrinberg
Copy link
Owner

Including the tests in the Python package is actually a mistake, there is no point in installing tests when users install the package, so I'm going to remove them. If you need to run the tests then get them directly from GitHub.

@arunpersaud
Copy link
Author

ok. Although many other packages include them in the tar-ball on pypi. This makes it easier for distributions to package, since they like to run the tests ;) Also, if you download the tar-ball from pypi and not the wheel, you might actually want to run the test?

@miguelgrinberg
Copy link
Owner

This is a neverending discussion that I don't think we'll be able to settle here. The fact is that the vast majority of people do not need or care about the tests when they install the package with pip, they just want the install to be as fast as possible. I don't install tests on my packages, this one slipped, it seems this was done many years ago and I didn't realize I was still shipping tests.

@arunpersaud
Copy link
Author

sounds good. I'll pull in the test from github. Thanks for the fast response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants