Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Is it possible to make template urls relative? #153

Open
tandrewnichols opened this issue Mar 22, 2018 · 8 comments
Open

Question: Is it possible to make template urls relative? #153

tandrewnichols opened this issue Mar 22, 2018 · 8 comments

Comments

@tandrewnichols
Copy link
Contributor

It's not clear to me from the docs how to do this (other than a custom function for transformUrl). I was very surprised this isn't the default, as that is the default for the grunt version of this plugin (I'm in the process of migrating some code from grunt to gulp).

Specifically, I would've expected something like:

$templateCache.put('template/foo.html', 'content')

but instead I'm getting

$templateCache.put('/template/foo.html', 'content')
@akash-pal
Copy link

This issue is not there in gulp 3.9.1
From gulp 4.0.0 this is an issue

@dmellstrom
Copy link
Contributor

This is because gulp 4 uses vinyl 2.0 which normalizes internal path records, breaking the url building logic. Here is the workaround I am using. I'm working on a PR to address this.

      transformUrl: function(url) {
        // Remove leading slash which occurs in gulp 4
        return url.replace(/^\/+/g, '');
      }

@simonua
Copy link
Collaborator

simonua commented Nov 7, 2018

Reopening due to breaking change with Gulp 3 after fixing this for Gulp 4 in 2.2.4. The code has since been reverted and 2.2.5 was published to reestablish status quo prior to this fix.

@simonua simonua reopened this Nov 7, 2018
@adamreisnz
Copy link

The transformUrl solution does the job for now

@dmellstrom
Copy link
Contributor

I'm working on getting access to a Mac so I can replicate and address the regression with 2.2.4 and find an alternative solution. In the meantime, we have transformUrl

@betorobson
Copy link

the first attempt workaround works find on unix base system however, my team mate here is running on Windows so guess what?
Windows slash is diferente kkkk.

So here my workaround update:

				transformUrl: function(url) {
					// Remove leading slash which occurs in gulp 4
					// https://github.com/miickel/gulp-angular-templatecache/issues/153
					return url.replace(/^(\\|\/)+/g, '');
				}

@simonua
Copy link
Collaborator

simonua commented Nov 27, 2018

Depending on how this issue progresses, it might be worthwhile expanding the Readme for specific gulp and OS combinations. What are your thoughts?

LukeGaudreau added a commit to BCLibraries/primo-explore-devenv that referenced this issue Jul 30, 2020
This works around a problem introduced by gulp 4 / vinyl 2:
miickel/gulp-angular-templatecache#153
NoamaExl pushed a commit to ExLibrisGroup/primo-explore-devenv that referenced this issue Jul 30, 2020
@AshokKumarSharma
Copy link

It's not clear to me from the docs how to do this (other than a custom function for transformUrl). I was very surprised this isn't the default, as that is the default for the grunt version of this plugin (I'm in the process of migrating some code from grunt to gulp).

Specifically, I would've expected something like:

$templateCache.put('template/foo.html', 'content')

but instead I'm getting

$templateCache.put('/template/foo.html', 'content')

i am also getting the same issue . Is there any work around for this to remove the Leading slash added to filenames

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants