Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with yarn workspaces #142

Open
shyshy opened this issue Oct 3, 2019 · 0 comments · May be fixed by #143
Open

Incompatibility with yarn workspaces #142

shyshy opened this issue Oct 3, 2019 · 0 comments · May be fixed by #143

Comments

@shyshy
Copy link

shyshy commented Oct 3, 2019

Trying to pull the package into a yarn workspace'd Ember application (latest version) and I get the following error:

Attempting to watch missing directory: node_modules/monaco-editor/dev/vs

I can get around this error by installing monaco-editor as a direct dependency in my app and using nohoist to get it to build at the nested node_modules level. I run into a similar error, however, for regenerator-runtime.

I have a working branch that gets around this by resolving the package paths by stepping up the parent tree. I can push that up if that sounds like it would fix it!

Example:

    const regeneratorPath = require.resolve('regenerator-runtime')
      .split('/')
      .slice(0, -1)
      .join('/');

    const regeneratorTree = maybeDebug(
      new Funnel(regeneratorPath, {
        destDir: '.'
      }),
      '1.1-regenerator-src'
    );
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant