Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible method getRelationCountHash after update to 8.17.2 #386

Open
webard opened this issue Dec 3, 2020 · 1 comment
Open

Incompatible method getRelationCountHash after update to 8.17.2 #386

webard opened this issue Dec 3, 2020 · 1 comment
Assignees

Comments

@webard
Copy link

webard commented Dec 3, 2020

ErrorException (Declaration of Kalnoy\Nestedset\BaseRelation::getRelationCountHash() should be compatible with Illuminate\Database\Eloquent\Relations\Relation::getRelationCountHash($incrementJoinCount = true)) thrown while looking for class Kalnoy\Nestedset\DescendantsRelation.

after update to the lates version 8.17.2

@webard webard changed the title Incompatible method getRelationCountHash after update to 8.0.17 Incompatible method getRelationCountHash after update to 8.17.2 Dec 3, 2020
@mikebronner mikebronner self-assigned this Dec 11, 2020
@mikebronner
Copy link
Owner

Hi @webard, thanks for submitting this issue! :) I will try to see what's going on as soon as possible, no promises though, as we are in the middle of moving. I would welcome PRs with failing tests and fixes, if you find yourself in a position to submit them. :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants