Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multi source configuration #996

Merged
merged 2 commits into from Jan 3, 2023
Merged

Add support for multi source configuration #996

merged 2 commits into from Jan 3, 2023

Conversation

mikepenz
Copy link
Owner

@mikepenz mikepenz commented Jan 3, 2023

  • add support for configs to be provided from file and json
    • define priority on the config json from YML, followed by file, last with the default value
    • Simplify code by merging configs right away
    • thanks for the suggestion @dtcMLOps

Sample Usecase:

  • configure base config via file (e.g. as template) -> provide specifics via YML

@mikepenz
- add support for configs to be provided from file and json
77b2076 
  - define priority on the config json from YML, followed by file, last with the default value
  - Simplify code by merging configs right away
  - thanks for the suggestion @dtcMLOps
@mikepenz mikepenz merged commit e1556de into develop Jan 3, 2023
@dtcMLOps
Copy link

dtcMLOps commented Jan 3, 2023

Hi @mikepenz, this is a really superb feature. We this we can avoid having a reusable workflow for sharing common style configurations between projects. Relates to #986.

@mikepenz
Copy link
Owner Author

mikepenz commented Jan 6, 2023

@dtcMLOps released as v3.6.0

@mikepenz mikepenz deleted the feature/merge_configs branch February 15, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikepenz @dtcMLOps