Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(knex): allow using knex query builder as virtual entity expression #4740

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Sep 24, 2023

Related: #4628

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage is 94.44% of modified lines.

❗ Current head c7428af differs from pull request most recent head a83e726. Consider uploading reports for the commit a83e726 to get more accurate results

Files Changed Coverage
packages/core/src/drivers/DatabaseDriver.ts ø
packages/core/src/typings.ts ø
packages/knex/src/AbstractSqlDriver.ts 94.44%

📢 Thoughts on this report? Let us know!.

@B4nan B4nan merged commit 427cc88 into master Sep 24, 2023
7 of 9 checks passed
@B4nan B4nan deleted the virtual-entities-knex-qb branch September 24, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant