Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-builder): merge raw join results in qb.execute() #4825

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Oct 15, 2023

Previously, the qb.execute() method returned cartesian product when joining to-many relations. Now the results will be automatically merged, as if you would map the results via qb.getResult().

Closes #4816
Related #4741

Previously, the `qb.execute()` method returned cartesian product when joining to-many relations.
Now the results will be automatically merged, as if you would map the results via `qb.getResult()`.

Closes #4816
Related #4741
packages/knex/src/AbstractSqlDriver.ts Dismissed Show dismissed Hide dismissed
packages/knex/src/AbstractSqlDriver.ts Dismissed Show dismissed Hide dismissed
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
packages/core/src/utils/Utils.ts 99.40% <ø> (-0.03%) ⬇️
packages/knex/src/AbstractSqlDriver.ts 98.94% <100.00%> (-0.88%) ⬇️
packages/knex/src/query/QueryBuilder.ts 99.40% <100.00%> (+<0.01%) ⬆️

📢 Thoughts on this report? Let us know!.

@B4nan B4nan merged commit 5a28e9b into master Oct 15, 2023
12 of 13 checks passed
@B4nan B4nan deleted the qb-merge-raw-results branch October 15, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant