Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): use write connection for fetching changes after upsert/upsertMany #4872

Merged
merged 2 commits into from
Oct 23, 2023
Merged

fix(core): use write connection for fetching changes after upsert/upsertMany #4872

merged 2 commits into from
Oct 23, 2023

Conversation

Arcus16
Copy link
Contributor

@Arcus16 Arcus16 commented Oct 23, 2023

Fixes #4868

@Arcus16 Arcus16 mentioned this pull request Oct 23, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
packages/core/src/EntityManager.ts 98.61% <ø> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@B4nan
Copy link
Member

B4nan commented Oct 23, 2023

thanks!

@B4nan B4nan merged commit 6b444ed into mikro-orm:master Oct 23, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upsert is using read replica for select
2 participants
@Arcus16 @B4nan