One-to-One relationship is not populated in the inverse side

[thiagomini]

Describe the bug

• Given we have a relationship of One-to-One: 1 User has 1 Profile
• And the User side is the inverse side (it holds the profile_id column)
• And There is a managed user entity
• When we create a new Profile passing the user's id as a parameter, and using the Reference.createFromPK(User, user.id) strategy
• Then the user's profile_id is not correctly populated (and therefore, the profile_id is not updated in the database

Stack trace

 FAIL  src/mikro-orm.test.ts > Mikro Orm > creates a user and assign a profile to it (using id)
AssertionError: expected null to be truthy

- Expected: 
null

+ Received: 
false

 ❯ src/mikro-orm.test.ts:73:37
     71|       refresh: true
     72|     });
     73|     expect(userWithProfile.profile).toBeTruthy()
       |                                     ^
     74|   });
     75| });

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

 Test Files  1 failed (1)
      Tests  1 failed | 1 passed (2)
   Start at  16:24:34
   Duration  1.38s (transform 200ms, setup 0ms, collect 119ms, tests 215ms, environment 0ms, prepare 216ms)

To Reproduce
Steps to reproduce the behavior:

1. Clone the minimum reproducible code repository: https://github.com/thiagomini/mikro-orm-repro/tree/bug/bidirectional-relationship
2. run yarn
3. run docker compose up -d
4. run yarn test

Expected behavior
the profile_id should be populated in the user side

Additional context

Here are some logs for the failing test:

stdout | src/mikro-orm.test.ts > Mikro Orm > creates a user and assign a profile to it (using id)
[query] begin

stdout | src/mikro-orm.test.ts > Mikro Orm > creates a user and assign a profile to it (using id)
[query] insert into "test"."user" ("first_name", "last_name", "email", "created_at", "updated_at") values ('firstName', 'lastName', 'email@mail.com', '2023-10-26T19:24:35.495Z', '2023-10-26T19:24:35.495Z') returning "id" [took 1 ms]
[query] commit

stdout | src/mikro-orm.test.ts > Mikro Orm > creates a user and assign a profile to it (using id)
[query] begin

stdout | src/mikro-orm.test.ts > Mikro Orm > creates a user and assign a profile to it (using id)
[query] insert into "test"."profile" ("id", "image_url", "active") values ('0', 'https://example.com', true) returning "id", "active" [took 1 ms]
[query] commit

stdout | src/mikro-orm.test.ts > Mikro Orm > creates a user and assign a profile to it (using id)
[query] select "u0".* from "test"."user" as "u0" where "u0"."id" = '1' limit 1 [took 1 ms, 1 result]

As you can see, the user.profile_id column is not updated.

Versions

Dependency	Version
node	18.12.1
typescript	5.0.4
mikro-orm	5.8.4
pg	8.11.2

[thiagomini]

Just one additional info, @B4nan: This test case passes when we pass the User instance instead of its id. So, the issue is probably related to the Reference.createFromPK() method.

I also believe the issue is somewhere in the defineReferenceProperties method:

mikro-orm/packages/core/src/entity/EntityHelper.ts

Line 150 in 70b75a5

set(val: AnyEntity | Reference<AnyEntity>) {

IIRC, it was not recognizing the Ref with an Id as a reference

[thiagomini]

Hey again, @B4nan, sorry for bothering you with this - but could you shed some light for us on where we could look in the code to find the root cause for that? The info above was all that I was able to find out so far. Thanks, man!

[B4nan]

FYI you dont need that conditional logic in your constructor:

mikro-orm/tests/features/unit-of-work/GH4879.test.ts

Line 22 in 9b2c9fe

this.user = ref(User, props.userOrId);

[thiagomini]

Thank you very much for the fix and the hint, Martin! We truly appreciate it!