Turning validate off on EntityManager Population should not trigger invalidPropertyName Error

[ThatOneAwkwardGuy]

Describe the bug

I have a polymorphic schema, which may or may not have a property i'd like to be populated. I've turned validation off when using this.em.populate however I'm still receiving invalidPropertyName errors.

Reproduction

@Entity({
  discriminatorColumn: 'type',
  abstract: true,
  discriminatorMap: {
	'child1': 'Child1',
	'child2': 'Child2'
  },
})
export abstract class Base  {
  @Property({ nullable: true })
  type? string;
}

export class Child1 extends Base {
  @Property()
  type: "child1";
}

export class Child2 extends Base {
  @Property()
  type: "child2";

  @ManyToOne(() => BankingAccount, { ref: true })
  account: Ref<BankingAccount>;	
}

// This will throw a invalidPropertyName error even though the entity could have account as a property. 
// I think it's fine that it does this and will prevent others making mistakes, but I need a way to turn it off.

await this.em.populate(entity, ["account"], {validate: false})

What driver are you using?

@mikro-orm/mongodb

MikroORM version

6.0.0-dev.284

Node.js version

20

Operating system

Mac

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Slack.
• The provided reproduction is a minimal reproducible example of the bug.

[B4nan]

await this.em.populate(entity, ["account"], {validate: false})

What is entity here? What error do you get? Include the stack trace so it's clear where it's thrown from.

My guess is its coming from the EM, not entity loader. FWIW this options is rather internal.

[ThatOneAwkwardGuy]

Actual stack trace

[2] [0] [Nest] 71051  - 22/12/2023, 18:11:41   ERROR [ExceptionsHandler] Entity 'BusinessAssetManualOther' does not have property 'ticker'
[2] [0] ValidationError: Entity 'BusinessAssetManualOther' does not have property 'ticker'
[2] [0]     at Function.invalidPropertyName (test/node_modules/.pnpm/@mikro-orm+core@6.0.0-dev.284_patch_hash=pip6vhquwj3ln44si6axk5oway/node_modules/@mikro-orm/core/errors.js:58:16)
[2] [0]     at MongoEntityManager.preparePopulate (test/node_modules/.pnpm/@mikro-orm+core@6.0.0-dev.284_patch_hash=pip6vhquwj3ln44si6axk5oway/node_modules/@mikro-orm/core/EntityManager.js:1517:44)
[2] [0]     at MongoEntityManager.populate (test/node_modules/.pnpm/@mikro-orm+core@6.0.0-dev.284_patch_hash=pip6vhquwj3ln44si6axk5oway/node_modules/@mikro-orm/core/EntityManager.js:1303:37)
[2] [0]     at test/dist/apps/api/main.js:48434:81
[2] [0]     at Array.map (<anonymous>)
[2] [0]     at AssetService.getPopulatedAssets (test/dist/apps/api/main.js:48434:58)
[2] [0]     at processTicksAndRejections (node:internal/process/task_queues:95:5)
[2] [0]     at AssetController.getAssets (test/dist/apps/api/main.js:48238:24)
[2] [0]

modified to suite example:

[2] [0] [Nest] 71051  - 22/12/2023, 18:11:41   ERROR [ExceptionsHandler] Entity 'Child1' does not have property 'ticker'
[2] [0] ValidationError: Entity 'Child1' does not have property 'account'
[2] [0]     at Function.invalidPropertyName (test/node_modules/.pnpm/@mikro-orm+core@6.0.0-dev.284_patch_hash=pip6vhquwj3ln44si6axk5oway/node_modules/@mikro-orm/core/errors.js:58:16)
[2] [0]     at MongoEntityManager.preparePopulate (test/node_modules/.pnpm/@mikro-orm+core@6.0.0-dev.284_patch_hash=pip6vhquwj3ln44si6axk5oway/node_modules/@mikro-orm/core/EntityManager.js:1517:44)
[2] [0]     at MongoEntityManager.populate (test/node_modules/.pnpm/@mikro-orm+core@6.0.0-dev.284_patch_hash=pip6vhquwj3ln44si6axk5oway/node_modules/@mikro-orm/core/EntityManager.js:1303:37)
[2] [0]     at test/dist/apps/api/main.js:48434:81
[2] [0]     at Array.map (<anonymous>)
[2] [0]     at AssetService.getPopulatedAssets (test/dist/apps/api/main.js:48434:58)
[2] [0]     at processTicksAndRejections (node:internal/process/task_queues:95:5)
[2] [0]     at AssetController.getAssets (test/dist/apps/api/main.js:48238:24)
[2] [0]

[ThatOneAwkwardGuy]

Sorry, i also realised i forgot to answer what entity would be. entity could be either Child1 or Child2

[B4nan]

Got it, I think we could allow that in general even without the flag, it's just about checking the root entity metadata in there.

[ThatOneAwkwardGuy]

Got it, I think we could allow that in general even without the flag, it's just about checking the root entity metadata in there.

As in expanding the names it checks for by starting from the Base entity getting all possible property names?