Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Remove Class OR ID and not be forced to remove both #160

Open
DevIQAU opened this issue Sep 17, 2018 · 0 comments
Open

Ability to Remove Class OR ID and not be forced to remove both #160

DevIQAU opened this issue Sep 17, 2018 · 0 comments

Comments

@DevIQAU
Copy link

DevIQAU commented Sep 17, 2018

This is a general question as I am sure that there was a good reason to merge these two instead of allowing for the flexibility to only remove class or id attributes.
We have a situation where we cant to inline the CSS classes, but preserve the ID of the tag for use by other JS/JQuery code

So my question is whether it is an acceptable idea to split the current _stripIdAndClassAtrtibutes into 2 new ones:
_stripIdAttribute
_stripClassAttribute

Downside is that it is a breaking change - but that could be mitigated by adding new method signatures that take the new properties over the current single one

Any comments appreciated

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant