Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to update 1.0.0-canary.2 #252

Closed
khuezy opened this issue Jan 9, 2022 · 6 comments
Closed

Request to update 1.0.0-canary.2 #252

khuezy opened this issue Jan 9, 2022 · 6 comments

Comments

@khuezy
Copy link

khuezy commented Jan 9, 2022

Hi, thanks for this project. I want to try out the multiple_deployments flag using the latest 1.0.0-canary.1 build but I'm getting:

"This object does not have an attribute named "cloudfront_origin_image_optimizer". I believe that fix hasn't been picked into the canary release.

Is there a way around this or do I just need to wait for an update.
Thanks!

EDIT: nvm I can edit the main.tf inside .terraform. Would be nice to get this fixed though.

@ofhouse
Copy link
Member

ofhouse commented Jan 11, 2022

Hey,

I will try to push an updated version by the end of the week. 👍

@khuezy
Copy link
Author

khuezy commented Jan 11, 2022

Thank you very much!

@ofhouse
Copy link
Member

ofhouse commented Jan 16, 2022

Applied a pretty big rebase on it (to sync it with the current main branch).
So I have to test it first before releasing a new prerelease version.

@ofhouse
Copy link
Member

ofhouse commented May 31, 2022

A little late, but v1.0.0-canary.2 is finally live 😅
Please note that this is a complete rewrite of v1.0.0-canary.1 so there is no smooth upgrade path from that.

@ofhouse ofhouse closed this as completed May 31, 2022
@khuezy
Copy link
Author

khuezy commented May 31, 2022

Awesome thanks! @ofhouse Do you think this atomic deployment will fix the issue #284?

@ofhouse
Copy link
Member

ofhouse commented May 31, 2022

No, this is unrelated to the atomic deployment feature.
This will be fixed probably with #86 and/or #11.

Since Vercel has open sourced their builder scripts for Next.js again, I will likely drop our fork (packages/runtime) of it that is now ~1.5 years old and use their updated builder instead.
So my hope is that switching to the server target resolves some issues with newer versions of Next.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants