Bug: highlighting stops a few minutes after writing

[ashton314]

I don't have a concrete way of reproducing this yet; I'll let you know if I manage to reproduce this with a small example. I just wanted to get an issue up in case others are experiencing the same problem.

I'll be writing with jinx-mode turned on, and after some time, or some number of characters—I don't know—highlighting will stop working.

I tried this out in a plain *scratch* buffer with text-mode and jinx-mode on. I was able to get the problem to surface after a minute or so of typing. Other modes enabled at the time:

M-x describe-variable RET minor-mode-list RET

(vertico-indexed-mode vertico-buffer-mode vc-dir-git-mode electric-pair-mode vertico-grid-mode buffer-face-mode text-scale-mode global-jinx-mode jinx-mode global-treesit-auto-mode treesit-auto-mode transient-resume-mode combobulate-mode diff-minor-mode diff-auto-refine-mode eshell-var-mode eshell-proc-mode eshell-arg-mode eat-trace-mode eat-eshell-visual-command-mode eat-eshell-mode eat--eshell-local-mode eat--eshell-char-mode eat--eshell-semi-char-mode eat--eshell-process-running-mode eat--line-mode eat--mouse-movement-mode eat--mouse-modifier-click-mode eat--mouse-click-mode eat--char-mode eat--semi-char-mode eat--cursor-blink-mode eat-blink-mode corfu-popupinfo-mode corfu-history-mode global-corfu-mode corfu-mode symbol-overlay-mode marginalia-mode vertico-multiform-mode vertico-mode avy-linum-mode pulsar-global-mode pulsar-mode mlscroll-mode olivetti-mode global-hl-line-mode hl-line-mode consult-notes-org-headings-mode consult-notes-org-roam-mode consult-notes-denote-mode consult-preview-at-point-mode denote-modules-global-mode denote-modules-mode denote-menu-bar-mode denote-dired-mode xref-etags-mode global-evil-surround-mode evil-surround-mode evil-owl-mode global-evil-collection-unimpaired-mode evil-collection-unimpaired-mode evil-collection-eldoc-doc-buffer-mode global-origami-mode origami-mode global-dash-fontify-mode dash-fontify-mode global-reveal-mode reveal-mode shell-highlight-undef-mode shell-dirtrack-mode comint-fontify-input-mode evil-mode evil-local-mode rectangle-mark-mode gcmh-mode apheleia-global-mode apheleia-mode puni-global-mode puni-mode treesit-explore-mode treesit-inspect-mode doc-view-presentation-mode doc-view-minor-mode image-minor-mode dired-hide-details-mode windmove-mode winner-mode pixel-scroll-precision-mode pixel-scroll-mode cua-mode global-auto-revert-mode auto-revert-tail-mode auto-revert-mode elpaca-use-package-mode override-global-mode elpaca-ui-tail-mode elpaca-ui-live-update-mode elpaca-no-symlink-mode cl-old-struct-compat-mode display-time-mode savehist-mode tooltip-mode global-eldoc-mode eldoc-mode show-paren-mode electric-quote-mode electric-layout-mode electric-indent-mode mouse-wheel-mode tool-bar-mode paragraph-indent-minor-mode global-prettify-symbols-mode prettify-symbols-mode use-hard-newlines tab-bar-history-mode tab-bar-mode menu-bar-mode file-name-shadow-mode isearch-fold-quotes-mode lost-selection-mode horizontal-scroll-bar-mode context-menu-mode jit-lock-debug-mode global-font-lock-mode font-lock-mode blink-cursor-mode window-divider-mode undelete-frame-mode completion-in-region-mode visible-mode buffer-read-only size-indication-mode column-number-mode line-number-mode auto-fill-function global-visual-line-mode visual-line-mode indent-tabs-mode transient-mark-mode cursor-face-highlight-mode read-extended-command-mode next-error-follow-minor-mode auto-composition-mode auto-encryption-mode auto-compression-mode temp-buffer-resize-mode button-mode lock-file-mode auto-save-visited-mode auto-save-mode auto-fill-mode abbrev-mode overwrite-mode view-mode hs-minor-mode)

I did just try it with the following elpaca-test macro but no dice:

jinx_bug.el

;; -*- lexical-binding: t; -*-

(elpaca-test
  :interactive t
  :early-init
  (setq byte-compile-warnings '(not obsolete))
  (setq inhibit-startup-screen t)
  :init
  (load-theme 'modus-vivendi :no-confirm)
  (elpaca jinx)
  (elpaca-wait)

  (use-package jinx
    :defer t
    :hook ((text-mode . jinx-mode)
           (prog-mode . jinx-mode))
    :bind (("C-;" . jinx-correct))
    :custom
    (jinx-camel-modes '(prog-mode))
    (jinx-delay 0.1)))

I will report back if I can find some more consistent pattern. In the mean time: is anyone else seeing this behavior?

[ashton314]

(Sorry this isn't the best bug report!)

[minad]

It could be that the idle time is not allowed to run. This could happen when your Emacs is never idle.

[ashton314]

Interesting… is there a way I could check this? (And figure out what's keeping Emacs awake?)

I did notice that hitting my jinx-correct key did find the closest misspelled word and highlighted then, so that seems viable.

[minad]

Ashton Wiersdorf ***@***.***> writes:

Interesting… is there a way I could check this? (And figure out what's keeping Emacs awake?)

Maybe try the profiler? I remember that I had similar issues before, where idle timers did not run. Coincidentally the culprit back then was Flyspell, which prevented the Corfu idle timer from running. I didn't have such problems for a long time since I take care to only enable efficient minor modes.

[ashton314]

Small update: I'm not seeing the behavior when I've got aa7ab4c checked out. I might bisect later to see if I can find the precise change causing this. My guess would be that Jinx is now relying on something that another one of my packages broke. 🙃 We'll see.

[minad]

Ashton Wiersdorf ***@***.***> writes:

Small update: I'm not seeing the behavior when I've got aa7ab4c checked out. I might bisect later to see if I can find the precise change causing this.

There have been timer related changes. Please check also the commit d2caef2.

[minad]

Thanks. Thinking about this again, I suspect that the problematic commit is 03efb68. If this doesn't help, and if you find time please bisect or check every commit since aa7ab4c. There is no easier way, but there are not that many commits.

[minad]

@ashton314 I would like to tag a new release. It would be good to know if the issue is fixed now with 03efb68. Can you please check?

[ashton314]

So sorry to be so slow… paper deadline killed me off. Taking a look now

[ashton314]

Latest release seems to work! 👍🏼 Thank you for fixing this!