Option to list "Accept and Save" before suggested corrections

[ksafford]

When there are a large number of corrections, the options to Accept and Save the word in a personal dictionary, for the file, or for the session can be hidden.

For new users, it may not be obvious that those options exist. And anyhow, a user might simply prefer to have those listed first.

A custom variable like jinx--suggestions-first controlling the order these sections are pushed to the menu could be a nice option.

With a modest amount of guidance about how you'd like to handle this, I believe I could submit a branch to effect this.

[ksafford]

My initial thought was to create two functions; one to push the suggested words onto the menu, one to push the Accept and Save selections onto the menu and optionally call them in one order vs the other based on the flag.

I think this only needs to happen in jinx--correct-menu, but I haven't read every line of the code, so I could be wrong.

[ksafford]

I understand. Allow me to make the case briefly.

Personally, I've found myself using "Session" or "Personal" quite frequently. However, I use the spellchecker infrequently enough that I don't have the keys associated to those options memorized. So I first have to M-> (end-of-buffer) to make those choices visible. In the screenshots in the README, it's not necessary because only a small number of options for correction are listed. But in practice, I'm getting dozens, so the Accept and Save block is always hidden from view.

[minad]

Pressing M-> is a small price to pay and imho doesn't justify making this configurable with an ad-hoc option. When I use Jinx I mostly select from one of the offered corrections, so moving the special options to the front would feel noisy. The issue with making such minute details configurable is that there is no clear line on where to stop.

I think I would like to make this configurable if it would come as a side effect of a generalization of jinx--save-keys, which hopefully would not increase complexity. Right now jinx--save-keys only configures the special actions but one could imagine generalizing this somehow to a variable jinx--correct-menu, for example like this:

(defvar jinx--correct-menu
  `(dict-suggestions
    session-suggestions
    (save-personal ?@)
    (save-file ?*)
    (save-session ?+)))

[minad]

For more background - the jinx--save-keys variable is also private right now since the way to configure this menu is not yet fixed. Just recently I added mouse support which wasn't completely natural and somewhat conflicted with the existing design. If we add another variable jinx--suggestions-first, it will make it harder to change this again. If we instead go with a generalization as described before we end up with something cleaner and more flexible, maybe allowing for further tweaks by the user.

[ksafford]

Wanted to say I am liking this package. Best spellcheck UI I've found.

[minad]

Thanks!