New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project as database for create/retrain/finetune #9135
Conversation
# Conflicts: # mindsdb/api/executor/command_executor.py
@@ -61,11 +61,9 @@ def learn_process(data_integration_ref: dict, problem_definition: dict, fetch_da | |||
) | |||
) | |||
sqlquery = SQLQuery(query, session=sql_session) | |||
elif data_integration_ref['type'] == 'view': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe keep this for back compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't be used because it is removed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will break existing 'predictors' with data_integration_ref->>'type' = 'view'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, returned 'type=view' block
Description
Changes:
CREATE MODEL model FROM mindsdb (SELECT * FROM example_db.home_rentals) PREDICT rental_price;
Side feature: second context for conditional job
It will allow to run job like this, when we have LAST in both conditional and execution blocks
It creates second 'job-if' context to not change 'job' context and not hide new data from job.
Dependent on mindsdb/mindsdb_sql#373
Please include a summary of the change and the issue it solves.
Fixes #9051
Type of change
(Please delete options that are not relevant)
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist: