Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0.10 changed the StorageClass parameters preventing upgrade from v4.0.9 #908

Open
suever opened this issue Apr 23, 2024 · 1 comment
Open

Comments

@suever
Copy link

suever commented Apr 23, 2024

Describe the bug
The minor patch release v4.0.10 modified the parameters of the created StorageClass. Because storage classes are immutable, the storage class has to be recreated (but all volumes have to be removed first). This breaks the ability to upgrade from v4.0.9

To Reproduce
Install v4.0.9, create PVCs that use DirectPV, attempt an upgrade (in-place or offline) to v4.0.10

Expected behavior
The upgrade should succeed

Additional context
At the very least there should be some documentation of this breaking change and some suggestions on mitigation. Ideally the semantic versioning should reflect this as well.

Longer-term, changes to the StorageClass probably should not be made and instead a new storage class should be created via DirectPV. Care should also be taken such that the old parameters still work when adjusting the SC parameters as not everyone will be able/willing to migrate for a patch release

@suever suever changed the title v4.0.10 changed the StorageClass parameters v4.0.10 changed the StorageClass parameters preventing upgrade from v4.0.9 Apr 23, 2024
@balamurugana
Copy link
Member

  1. What is the error you are getting?
  2. Have you tried in-place upgrade by https://github.com/minio/directpv/blob/master/docs/upgrade.md#in-place-upgrade ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants