Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for SSE-C,SSE-S3 encryption #1043

Merged
merged 1 commit into from Jan 4, 2019
Merged

Add tests for SSE-C,SSE-S3 encryption #1043

merged 1 commit into from Jan 4, 2019

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Nov 15, 2018

This is blocked on minio/minio#6488 and Mint update to run server with MINIO_SSE_MASTER_KEY env set

@harshavardhana
Copy link
Member

Is this ready for review @poornas ?

@poornas
Copy link
Contributor Author

poornas commented Dec 31, 2018

@harshavardhana , yes it can be reviewed.

vadmeste
vadmeste previously approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested

@nitisht
Copy link
Contributor

nitisht commented Jan 2, 2019

ping @aead

aead
aead previously approved these changes Jan 3, 2019
View reviewed changes
@kannappanr
Copy link
Collaborator

Marking this as blocked until an environment variable is introduced to run SSE-S3 tests similar to the one in minio-dotnet

@poornas poornas dismissed stale reviews from aead and vadmeste via e5c0f46 January 4, 2019 00:37
@poornas
Copy link
Contributor Author

poornas commented Jan 4, 2019

@vadmeste and @aead, can you reapprove - added a env variable ENABLE_KMS to run SSE-S3 functional tests only when kms is set up

@kannappanr kannappanr removed the blocked label Jan 4, 2019
vadmeste
vadmeste approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit f1fd212 into minio:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@aead aead aead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@poornas @harshavardhana @nitisht @kannappanr @vadmeste @aead