fix(scrollable): fix CSS shadow effect #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `.moj-scrollable-pane` class is supposed to add shadows to indicate that its contents are scrollable, but it is not suitably dynamic. This CSS uses [scroll shadows][scroll-shadows] to make the shadows dynamically appear on the left and right when there's overflow content there. If there's no overflow content, or the container is scrolled all the way to one side, the shadows are hidden. I removed the `.moj-scrollable-pane__wrapper` class because it's unnecessary. [scroll-shadows]: https://www.bram.us/2019/10/24/pure-css-scroll-shadows-vertical-horizontal/
|
This PR is just to fix the existing CSS. Next week I'll add documentation so that people can use it independently. You can see it in action on the preview environment: open the "Filter a list" pattern and click "Show Filter" and you'll see the shadows appear as you scroll left and right. |
gregtyler
pushed a commit
that referenced
this pull request
Oct 28, 2022
## [1.6.1](v1.6.0...v1.6.1) (2022-10-28) ### Bug Fixes * **scrollable:** fix CSS shadow effect ([#381](#381)) ([dce18d4](dce18d4))
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.scrollable-paneclass is supposed to add shadows to indicate that its contents are scrollable, but it is not suitably dynamic.This CSS uses scroll shadows to make the shadows dynamically appear on the left and right when there's overflow content there.
If there's no overflow content, or the container is scrolled all the way to one side, the shadows are hidden.
I removed the
.moj-scrollable-pane__wrapperclass because it's unnecessary.