Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support Prototype Kit v13 #465

Closed
gregtyler opened this issue Mar 16, 2023 · 1 comment · Fixed by #466
Closed

Better support Prototype Kit v13 #465

gregtyler opened this issue Mar 16, 2023 · 1 comment · Fixed by #466
Labels
released

Comments

@gregtyler
Copy link
Contributor

v13 of the prototype kit no longer contains jQuery and doesn't manually init components, so our current installation instructions are insufficient.

We should update govuk-prototype-kit.config.json to include a version of the Pattern Library that has jQuery bundled into it, and to include an automatic init file.

See also alphagov/govuk-prototype-kit#1823
@gregtyler gregtyler mentioned this issue Mar 16, 2023
Merged
gregtyler added a commit that referenced this issue Mar 16, 2023
@gregtyler
fix(prototype): better support for GOV.UK Prototype Kit
59fa544 
Allow the Pattern Library to automatically be available in the Prototype Kit when installed.

This requires producing a file with jQuery bundled (`all.jquery.min.js`) and an init file
(`init.js`). When loaded into the Prototype Kit they automatically initialise all the components.

Update the documentation to explain that no further steps are necessary.

Fixes #465
gregtyler added a commit that referenced this issue Mar 21, 2023
@gregtyler
fix(prototype): better support for GOV.UK Prototype Kit (#466)
f2e6faa 
Allow the Pattern Library to automatically be available in the Prototype Kit when installed.

This requires producing a file with jQuery bundled (`all.jquery.min.js`) and an init file
(`init.js`). When loaded into the Prototype Kit they automatically initialise all the components.

Update the documentation to explain that no further steps are necessary.

Fixes #465
gregtyler pushed a commit that referenced this issue Mar 21, 2023
@semantic-release-bot
chore(release): 1.6.6 [skip ci]
536dc6a 
## [1.6.6](v1.6.5...v1.6.6) (2023-03-21)

### Bug Fixes

* **prototype:** better support for GOV.UK Prototype Kit ([#466](#466)) ([f2e6faa](f2e6faa)), closes [#465](#465)
@gregtyler
Copy link
Contributor Author

🎉 This issue has been resolved in version 1.6.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(prototype): better support for GOV.UK Prototype Kit ministryofjustice/moj-frontend
1 participant
@gregtyler