feat(filter component): add parameter for apply filters button text #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtyler
approved these changes
Jun 8, 2023
gregtyler
pushed a commit
that referenced
this pull request
Jun 8, 2023
# [1.8.0](v1.7.0...v1.8.0) (2023-06-08) ### Features * **filter component:** add parameter for apply filters button text ([#493](#493)) ([5362f1e](5362f1e))
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue or RFC endorsed by the maintainers
#486
Description of the change
Added the ability to override the filter component's 'Apply filters' text using the newly-added
submitsection of the component's parameters.Alternative designs
This text could be updated externally using JavaScript or similar, but this allows the users to configure it from within the application's parameters.
Possible drawbacks
Conceivably this functionality could be used to add a less descriptive or misleading description, but that would be an issue for the user themselves.
Verification process
The filter example was updated to verify this functionality locally, but updating the button description in the documentation permanently seemed to present the option as mandatory.
Release notes
Added the ability to override the filter component's 'Apply filters' button text.