Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.15 requires Node 10+, which seems like a breaking change from 0.4.14 #2111

Open
EndangeredMassa opened this issue Jan 22, 2021 · 1 comment

Comments

@EndangeredMassa
Copy link

I'm upgrading an old project from ember-cli-mirage@0.1.15. When I hit the step to upgrade to 0.4.*, I went for 0.4.15 to see what worked. I then saw that this dependency exists:

ember-cli-mirage@0.4.15 -> ember-auto-import -> jsdom -> webidl-conversions@6.0.0

Unfortunately, webidl-conversions@6.0.0 uses optional catch binding, which means it requires Node 10+. It seems that adding ember-auto-import is the source of this issue.

It looks like at the time of publication, ember-cli-mirage0.4.15 may have been compatible with Node 8. But now it is not.

I don't see any mention of explicit Node version support in ember-cli-mirage. However, going from 0.4.14 to 0.4.15 means that the supported Node version does change.

I don't know if you want to fix this. Feel free to close if not. But if you do, maybe a 0.4.16 release that locks that dependency down would be in order.

Regardless, can you add a breaking change note to 0.4.15 saying this is the case?

@samselikoff
Copy link
Collaborator

Updated the release notes, sorry you ran into that!

Happy to merge a PR that locks that dep + publish as 0.4.16, if someone gets around to it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants