Extension should only run on LaTeX builder

[Daltz333]

The extension currently runs on all builders, HTML, Gettext, Linkcheck, etc.

[sephalon]

The SVG to PDF converters are based on the Sphinx ImageConverter class that is only invoked if the builder does not support the image type. So this should not happen – could you please elaborate a bit more on what exactly you see?

[Daltz333]

There was a bug in upstream imgconverter where it would run is_available in all builders. This has been fixed and will be published in Sphinx 3.1.0

[Daltz333]

Reopening as this issue is still present in sphinx-build -b html. rsvg-convert should only run in the latexpdf builder

[sephalon]

sphinx-doc/sphinx#7978 has been merged by now. Does it solve the issue for you?

[Daltz333]

No. All that issue does is prevent it from running many times on those builders. This extension still runs on all builders.

[sephalon]

sphinx-doc/sphinx#8649 should finally fix this issue. Closed.

[mgeier]

I'm still getting an error, is this really solved?

See spatialaudio/nbsphinx#559 for details.

[Daltz333]

Works for me. That error you have looks like it's having an issue running rsvg-convert. Try running it by hand and verifying it works.

[mgeier]

Thanks for the quick answer @Daltz333!
I was expecting that rsvg-convert wouldn't be called at all when not needed, isn't that so?

I'm only generating HTML in the linked issue, so I would expect that rsvg-convert is not needed and doesn't have to be called.

I have intentionally not installed it for this situation.

[Daltz333]

Hm, are you using a custom builder to the standard HTML builder?

[mgeier]

Well I'm using some custom nodes and quite a few suspicious hacks in nbsphinx, but I think I'm using the standard HTML builder.

[Daltz333]

I attempted to build your documentation locally, but looks like it has several things line-endings related that prevents me (Windows) from building it.

This is the logic doing the skip

elif set(node['candidates']) & set(self.app.builder.supported_image_types):
            # builder supports the image; no need to convert
            return False

[mgeier]

I'm not changing anything regarding builder.supported_image_types, at least not knowingly.

looks like it has several things line-endings related that prevents me (Windows) from building it.

It would be great if you could create an issue for this!
I'd like to make it work on Windows, but I'm not a user myself ...

[mgeier]

@Daltz333 I looked into this again and I made a minimal reproducible example: https://github.com/mgeier/rsvgconverter-bug

At first I couldn't reproduce the problem, but then I found out that the error occurs when using a "data" URL instead of an image file, e.g.

.. image:: data:image/png;base64,....

I've added this to my test repo: mgeier/rsvgconverter-bug@82379d1.

Here's a failing test: https://github.com/mgeier/rsvgconverter-bug/runs/3274422618

Any idea how to fix this?

[mgeier]

I've created a Sphinx issue for this: sphinx-doc/sphinx#10073.