Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): avoid caching remote user's HTL when receiving Note #13772

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

zyoshoka
Copy link
Contributor

@zyoshoka zyoshoka commented Apr 30, 2024

What

リモートユーザーの投稿を受け取った際そのユーザーの HTL にキャッシュしないようにしました。

Why

Closes #13771

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Apr 30, 2024
Copy link
Contributor

github-actions bot commented Apr 30, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 65.09%. Comparing base (f8261a1) to head (bf2ff4b).
Report is 574 commits behind head on develop.

Files Patch % Lines
packages/backend/src/core/NoteCreateService.ts 28.57% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13772       +/-   ##
============================================
- Coverage    79.95%   65.09%   -14.87%     
============================================
  Files          956      985       +29     
  Lines       108864   112232     +3368     
  Branches      8413     4452     -3961     
============================================
- Hits         87045    73055    -13990     
- Misses       21819    39146    +17327     
- Partials         0       31       +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented May 1, 2024

この辺のテストってなかったっけ?
あったら追加できると良さそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary HTL cache for remote users
2 participants