Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): avoid notifying to remote users on local #13774

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

zyoshoka
Copy link
Contributor

What

ローカル上のリモートユーザーに対して通知を行わないようにしました。

Why

Closes #13773

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Apr 30, 2024
Copy link
Contributor

github-actions bot commented Apr 30, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 64.95%. Comparing base (2b8056a) to head (ef7e2b9).

Files Patch % Lines
packages/backend/src/core/NotificationService.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13774      +/-   ##
===========================================
- Coverage    64.95%   64.95%   -0.01%     
===========================================
  Files          989      989              
  Lines       112848   112853       +5     
  Branches      5770     5813      +43     
===========================================
- Hits         73306    73302       -4     
- Misses       38100    38109       +9     
  Partials      1442     1442              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary notification to remote users on local
1 participant