forked from JeremyHeleine/Photo-Sphere-Viewer
-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imageLayer rotation proportion #1252
Comments
for the demo sometimes you have to move the pano because the marker does not appear when created |
This feature/bug fix has been released in version 5.7.2. |
if I switch back to |
again: new problem, new issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When rotating imageLayer marker, proportion is not maintained.
using:
markersPlugin.updateMarker({ id: markerId, rotation: newDeg });
Also if you try to access the
rotation
of a marker and you didn't previously set arotation
, throws an error.I think
rotation
should be set to 0 if not specified at creation.for example here:
markersPlugin.addEventListener('select-marker', ({ marker, doubleClick, rightClick }) => { let rot = marker.config.rotation; });
Online demo URL
https://jsfiddle.net/ferpando/cpm6b8gz/1/
Photo Sphere Viewer version
5.7.1
Plugins loaded
markersPlugin
OS & browser
MacOs Sonoma, Brave Versión 1.62.162 Chromium: 121.0.6167.164 (Build oficial) (arm64)
Additional context
No response
The text was updated successfully, but these errors were encountered: