Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imageLayer rotation proportion #1252

Closed
Fernando-Checa opened this issue Mar 5, 2024 · 6 comments
Closed

imageLayer rotation proportion #1252

Fernando-Checa opened this issue Mar 5, 2024 · 6 comments
Labels
Milestone

Comments

@Fernando-Checa
Copy link

Describe the bug

When rotating imageLayer marker, proportion is not maintained.

using:
markersPlugin.updateMarker({ id: markerId, rotation: newDeg });

Also if you try to access the rotation of a marker and you didn't previously set a rotation, throws an error.
I think rotation should be set to 0 if not specified at creation.

for example here:
markersPlugin.addEventListener('select-marker', ({ marker, doubleClick, rightClick }) => { let rot = marker.config.rotation; });

Online demo URL

https://jsfiddle.net/ferpando/cpm6b8gz/1/

Photo Sphere Viewer version

5.7.1

Plugins loaded

markersPlugin

OS & browser

MacOs Sonoma, Brave Versión 1.62.162 Chromium: 121.0.6167.164 (Build oficial) (arm64)

Additional context

No response

@Fernando-Checa
Copy link
Author

for the demo sometimes you have to move the pano because the marker does not appear when created

@mistic100 mistic100 added this to the 5.7.2 milestone Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

This feature/bug fix has been released in version 5.7.2.

@Fernando-Checa
Copy link
Author

Fernando-Checa commented Mar 6, 2024

Hello,

I get this error when changing panorama
CleanShot 2024-03-06 at 10 47 32

@Fernando-Checa
Copy link
Author

this is the full error when doing

setPanorama(panorama, options)

CleanShot 2024-03-06 at 11 00 29

@Fernando-Checa
Copy link
Author

if I switch back to 5.7.1 everything works fine

@mistic100
Copy link
Owner

again: new problem, new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants