Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI C tests fail #1592

Closed
JasonGross opened this issue Apr 19, 2023 · 0 comments · Fixed by #1593
Closed

CI C tests fail #1592

JasonGross opened this issue Apr 19, 2023 · 0 comments · Fixed by #1593
Assignees
@andres-erbsen

Comments

@JasonGross
Copy link
Collaborator

Since https://boringssl.googlesource.com/boringssl/+/aa31748bc84f0cd499e4b0337bf929b132aab1cc, our C tests fail with cp: cannot stat '/home/runner/work/fiat-crypto/fiat-crypto/fiat-c/src/curve25519_64_msvc.c': No such file or directory

Should we adjust

fiat-crypto/etc/ci/test-fiat-c-boringssl.sh

Line 29 in 457cb5e

( cd third_party/fiat && for i in *.h; do cp "${SUBCOMPONENT_PATH}/${i/.h/.c}" "$i" || exit $?; done ) || exit $?
to exclude these files?

Should we fix #1560?
JasonGross added a commit to JasonGross/fiat-crypto that referenced this issue Apr 19, 2023
@JasonGross
Exclude curve25519_64_msvc.c
e097a87 
Quick fix for mit-plv#1592
@JasonGross JasonGross mentioned this issue Apr 19, 2023
Merged
JasonGross added a commit to JasonGross/fiat-crypto that referenced this issue Apr 19, 2023
@JasonGross
Exclude curve25519_64_msvc.c
5f4263b 
Quick fix for mit-plv#1592
JasonGross added a commit that referenced this issue Apr 20, 2023
@JasonGross
Exclude curve25519_64_msvc.c (#1593)
fcc467e 
Quick fix for #1592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andres-erbsen andres-erbsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude curve25519_64_msvc.c JasonGross/fiat-crypto
2 participants
@JasonGross @andres-erbsen