Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate authentication app #3

Open
4 tasks
rhysyngsun opened this issue Aug 28, 2020 · 0 comments
Open
4 tasks

Migrate authentication app #3

rhysyngsun opened this issue Aug 28, 2020 · 0 comments

Comments

@rhysyngsun
Copy link
Collaborator

rhysyngsun commented Aug 28, 2020

We have a few existing implementations of authentication, these are largely the same:

Open: https://github.com/mitodl/open-discussions/tree/master/authentication
xPro: https://github.com/mitodl/mitxpro/tree/master/authentication
Bootcamps: http://github.com/mitodl/bootcamp-ecommerce/tree/master/authentication

Bootcamps represents the most up-to-date implementation with a few bug fixes and improvements. xPro is the next most recent version and Open is the original implementation. Generally speaking this app wraps django-social-auth in a REST API in order for React-based UIs to call it.

I started a port of the application a while back (I've rebased this, but it's probably in a broken state otherwise): https://github.com/mitodl/ol-django/compare/nl/add-auth-app

  • Pull out reuseable authentication app logic
  • Social auth actions need to return SocialAuthState directly
  • Combine separate API endpoints into a single one
    • Typically implementations make per-state API endpoints, this isn't strictly necessary, adds unnecessary complexity, and would be difficult to port into a reusable app
  • User creation will be up to the integrating app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant