Use inline block format also for strings of form "foo\n" #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated inline strings for snapshots with a single trailing
newline currently look something like this:
```
insta::assert_snapshot!(stdout, @"foo
");
```
The unindented line there is distracting. I think it looks neater with
the block-style strings, like this:
```
insta::assert_snapshot!(stdout, @###"
foo
"###);
```
I suspect the reason it isn't currently generated like that is just an
oversight caused by the fact that Rust's `str::lines()` returns a
single line for that kind of strings. This patch fixes it by looking
for `\n` characters instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated inline strings for snapshots with a single trailing
newline currently look something like this:
The unindented line there is distracting. I think it looks neater with
the block-style strings, like this:
I suspect the reason it isn't currently generated like that is just an
oversight caused by the fact that Rust's
str::lines()returns asingle line for that kind of strings. This patch fixes it by looking
for
\ncharacters instead.