Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending snapshot in nested crate is double-counted #388

Open
max-sixty opened this issue Jun 27, 2023 · 0 comments
Open

Pending snapshot in nested crate is double-counted #388

max-sixty opened this issue Jun 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@max-sixty
Copy link
Sponsor Contributor

max-sixty commented Jun 27, 2023

What happened?

We have a layout like:

prql-compiler
|- Cargo.toml
|- src
|- ...
|- prqlc
   |- Cargo.toml
   |- src
   |- ...

When there's a single pending snapshot inside prqlc:

  • insta reports "2 pending snapshots"
  • On cargo insta review, if the first is accepted or rejected, we get an "File not found" error when it attempts to find the file for the second time (Being more permissive to files changing under insta #380)
  • If we skip, the only change between the two within cargo insta review is that the crate changes from prqlc to prql-compiler

Insta Version

1.30

rustc Version

1.68

@max-sixty max-sixty added the bug Something isn't working label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant