Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-insta review emits "Snapshot" with everything after a period removed #401

Closed
tamird opened this issue Sep 8, 2023 · 0 comments · Fixed by #483
Closed

cargo-insta review emits "Snapshot" with everything after a period removed #401

tamird opened this issue Sep 8, 2023 · 0 comments · Fixed by #483
Labels
bug Something isn't working

Comments

@tamird
Copy link
Contributor

tamird commented Sep 8, 2023

What happened?

In cargo-insta review I see

Reviewing [1/1] foo@0.1.0:
Snapshot file: foo/src/snapshots/go1.20.5.snap
Snapshot: go1
Source: foo/src/lib.rs:290

It looks as though the intent is to strip off ".snap" but instead everything after the first period is stripped.

Reproduction steps

No response

Insta Version

1.31.0

rustc Version

1.72.0

What did you expect?

The full snapshot name should be shown.
@tamird tamird added the bug Something isn't working label Sep 8, 2023
max-sixty added a commit to max-sixty/insta that referenced this issue May 2, 2024
@max-sixty
Fix snapshot & module name extraction
66aff45 
Fixes mitsuhiko#401 as well as most (but not all) of mitsuhiko#477
@max-sixty max-sixty mentioned this issue May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix snapshot & module name extraction max-sixty/insta
1 participant
@tamird