Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support test execution with Miri #429

Open
farnoy opened this issue Nov 25, 2023 · 1 comment
Open

Support test execution with Miri #429

farnoy opened this issue Nov 25, 2023 · 1 comment

Comments

@farnoy
Copy link

farnoy commented Nov 25, 2023

I'm using inline snapshots and INSTA_UPDATE=no. My tests otherwise work with Miri, they're only failing because of assert_snapshot!

The root cause seems to be trying to parse the Cargo manifest for ToolConfig. This is after working around auto-discovery issues with INSTA_WORKSPACE_ROOT - insta::env::ToolConfig::from_workspace

Looking at what ToolConfig does, it seems to be possible to come up with default values for cfg!(miri), like not updating the snapshots, etc.

@mitsuhiko
Copy link
Owner

I'm not sure what a good solution here is, but I'm happy to accept a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants