Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: custom headers in a snap file #433

Open
quantori-pokidovea opened this issue Dec 12, 2023 · 4 comments
Open

Feature request: custom headers in a snap file #433

quantori-pokidovea opened this issue Dec 12, 2023 · 4 comments

Comments

@quantori-pokidovea
Copy link

That would be nice to have an extra context inside the snap file. For example

---
source: src/secondary_structure/bulge.rs
expression: bulge
---
sense: TCCCCTAGCTTTTAGCTATGGGGA
anti_sense: AGGGGTATCGATTTTCGATCCCCT
forward_init_x: 6
---
Bulge {
    description: "/bulge(-T)",
    entropy: Entropy(
        -35.510002,
    ),
    enthalpy: Enthalpy(
        -7.8,
    ),
    interim_oligo: Some(
        Sequence(T),
    ),
    wc_stack: Some(
        WCStack(CT/GA),
    ),
}

So, we can see some circumstances which led to the snapshot's body.

@max-sixty
Copy link
Sponsor Contributor

Possibly description or debug_expr could be serialized using the same serializer — and then we could add fields without an additional field?

(it would be a small breaking change though, unless we did something like attempt both the serialized and unserialized versions)

@pokidovea
Copy link

It could be the same section as for the regular headers. It doesn't matter. The main idea is to be able to populate headers with custom ones.

@mitsuhiko
Copy link
Owner

Would you expect the review tool to show these headers?

@tyao1
Copy link

tyao1 commented Feb 29, 2024

Would love this feature as well. I would like to ignore the headers section, because we use buck internally and cargo externally, and they have different root directories for source and output files, I couldn't get snapshot to stay the same between two build systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants