Add require_full_match option
#448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May need some refining. Closes mitsuhiko#351, but with an additional option, since `force_update` seems like a bad term for this
|
I'm good with merging this though in practice I can only assume this is probably going to be a rare thing. |
Yes very possibly! Though I find that having old metadata can be confusing ("that input generated the output on an old version of the library?!") and so enforcing up-to-date metadata is useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May need some refining.
Closes #351, but with an additional option, since
force_updateseems like a bad term for thisIs this reasonable in principle?