Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo insta test --all-targets exits with an error when there are doctests #460

Open
ilyagr opened this issue Mar 15, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@ilyagr
Copy link

ilyagr commented Mar 15, 2024

What happened?

Fortunately, the error occurs after all the tests are run. So, a human being looking at the output will know to ignore it. However, cargo-insta does exit with a non-zero error code in this situation.

Cc #438 and #408. With #438, adding --disable-nextest-doctest fixes the problem (though I wouldn't call this an elegant fix).

Reproduction steps

  1. Clone https://github.com/martinvonz/jj/tree/3bbc3e5715eba28e79dad7528ccd8e9bc37b505b
  2. Run cargo insta test --accept --workspace --all-targets --test-runner nextest
  3. Observe the error at the end:
...
error: Can't mix --doc with other target selecting options
done: no snapshots to review

Insta Version

cargo-insta-test 1.36.1

rustc Version

rustc 1.78.0-nightly (3cbb93223 2024-03-13) binary: rustc commit-hash: 3cbb93223f33024db464a4df27a13c7cce870173

What did you expect?

No response

@ilyagr ilyagr added the bug Something isn't working label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant