Skip to content

Commit 4b5ee3c

Browse files
committedMar 9, 2024
tests: remove Object.assign
1 parent 849742f commit 4b5ee3c

File tree

1 file changed

+46
-30
lines changed

1 file changed

+46
-30
lines changed
 

‎test/license-plugin.spec.js

+46-30
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import tmp from 'tmp';
2828
import moment from 'moment';
2929
import {licensePlugin} from '../src/license-plugin.js';
3030
import {join} from './utils/join.js';
31+
import {pkg} from '../scripts/config';
3132

3233
describe('LicensePlugin', () => {
3334
let tmpDir;
@@ -202,9 +203,10 @@ describe('LicensePlugin', () => {
202203

203204
expect(addDependency).toHaveBeenCalled();
204205
expect(plugin._dependencies).toEqual({
205-
'fake-package': Object.assign(fakePackage, {
206+
'fake-package': {
207+
...fakePackage,
206208
licenseText: 'LICENSE.md file',
207-
}),
209+
},
208210
});
209211
});
210212

@@ -215,9 +217,10 @@ describe('LicensePlugin', () => {
215217

216218
expect(addDependency).toHaveBeenCalled();
217219
expect(plugin._dependencies).toEqual({
218-
'fake-package': Object.assign(fakePackage, {
220+
'fake-package': {
221+
...fakePackage,
219222
licenseText: null,
220-
}),
223+
},
221224
});
222225
});
223226

@@ -228,9 +231,10 @@ describe('LicensePlugin', () => {
228231

229232
expect(addDependency).toHaveBeenCalled();
230233
expect(plugin._dependencies).toEqual({
231-
'fake-package': Object.assign(fakePackage, {
234+
'fake-package': {
235+
...fakePackage,
232236
licenseText: 'license.md file',
233-
}),
237+
},
234238
});
235239
});
236240

@@ -241,9 +245,10 @@ describe('LicensePlugin', () => {
241245

242246
expect(addDependency).toHaveBeenCalled();
243247
expect(plugin._dependencies).toEqual({
244-
'fake-package': Object.assign(fakePackage, {
248+
'fake-package': {
249+
...fakePackage,
245250
licenseText: 'license.md file',
246-
}),
251+
},
247252
});
248253
});
249254

@@ -254,9 +259,10 @@ describe('LicensePlugin', () => {
254259

255260
expect(addDependency).toHaveBeenCalled();
256261
expect(plugin._dependencies).toEqual({
257-
'fake-package': Object.assign(fakePackage, {
262+
'fake-package': {
263+
...fakePackage,
258264
licenseText: 'LICENSE.txt file',
259-
}),
265+
},
260266
});
261267
});
262268

@@ -267,9 +273,10 @@ describe('LicensePlugin', () => {
267273

268274
expect(addDependency).toHaveBeenCalled();
269275
expect(plugin._dependencies).toEqual({
270-
'fake-package': Object.assign(fakePackage, {
276+
'fake-package': {
277+
...fakePackage,
271278
licenseText: 'LICENSE file',
272-
}),
279+
},
273280
});
274281
});
275282

@@ -443,9 +450,10 @@ describe('LicensePlugin', () => {
443450
});
444451

445452
it('should add dependency and parse author field', () => {
446-
const dependency = Object.assign(pkg, {
453+
const dependency = {
454+
...pkg,
447455
author: 'Mickael Jeanroy <mickael.jeanroy@gmail.com> (https://mjeanroy.com)',
448-
});
456+
};
449457

450458
plugin.addDependency(dependency);
451459

@@ -458,9 +466,10 @@ describe('LicensePlugin', () => {
458466
});
459467

460468
it('should add dependency and parse contributors field as a string', () => {
461-
const dependency = Object.assign(pkg, {
469+
const dependency = {
470+
...pkg,
462471
contributors: 'Mickael Jeanroy <mickael.jeanroy@gmail.com> (https://mjeanroy.com)',
463-
});
472+
};
464473

465474
plugin.addDependency(dependency);
466475

@@ -477,12 +486,13 @@ describe('LicensePlugin', () => {
477486
it('should add dependency and parse contributors field', () => {
478487
const contributor1 = 'Mickael Jeanroy <mickael.jeanroy@gmail.com> (https://mjeanroy.com)';
479488
const contributor2 = {name: 'John Doe', email: 'johndoe@doe.com'};
480-
const dependency = Object.assign(pkg, {
489+
const dependency = {
490+
...pkg,
481491
contributors: [
482492
contributor1,
483493
contributor2,
484494
],
485-
});
495+
};
486496

487497
plugin.addDependency(dependency);
488498

@@ -506,13 +516,14 @@ describe('LicensePlugin', () => {
506516
it('should add dependency and parse licenses field', () => {
507517
const mit = {type: 'MIT', url: 'http://www.opensource.org/licenses/mit-license.php'};
508518
const apache2 = {type: 'Apache-2.0', url: 'http://opensource.org/licenses/apache2.0.php'};
509-
const dependency = Object.assign(pkg, {
519+
const dependency = {
520+
...pkg,
510521
license: null,
511522
licenses: [
512523
mit,
513524
apache2,
514525
],
515-
});
526+
};
516527

517528
plugin.addDependency(dependency);
518529

@@ -1042,9 +1053,10 @@ describe('LicensePlugin', () => {
10421053
});
10431054

10441055
instance.addDependency(pkg1);
1045-
instance.addDependency(Object.assign(pkg2, {
1056+
instance.addDependency({
1057+
...pkg2,
10461058
private: true,
1047-
}));
1059+
});
10481060

10491061
instance.scanThirdParties();
10501062

@@ -1063,9 +1075,10 @@ describe('LicensePlugin', () => {
10631075
});
10641076

10651077
instance.addDependency(pkg1);
1066-
instance.addDependency(Object.assign(pkg2, {
1078+
instance.addDependency({
1079+
...pkg2,
10671080
private: true,
1068-
}));
1081+
});
10691082

10701083
instance.scanThirdParties();
10711084

@@ -1178,9 +1191,10 @@ describe('LicensePlugin', () => {
11781191
});
11791192

11801193
instance.addDependency(pkg1);
1181-
instance.addDependency(Object.assign(pkg2, {
1194+
instance.addDependency({
1195+
...pkg2,
11821196
private: true,
1183-
}));
1197+
});
11841198

11851199
instance.scanThirdParties();
11861200

@@ -1214,9 +1228,10 @@ describe('LicensePlugin', () => {
12141228
});
12151229

12161230
instance.addDependency(pkg1);
1217-
instance.addDependency(Object.assign(pkg2, {
1231+
instance.addDependency({
1232+
...pkg2,
12181233
private: true,
1219-
}));
1234+
});
12201235

12211236
instance.scanThirdParties();
12221237

@@ -1252,9 +1267,10 @@ describe('LicensePlugin', () => {
12521267
});
12531268

12541269
instance.addDependency(pkg1);
1255-
instance.addDependency(Object.assign(pkg2, {
1270+
instance.addDependency({
1271+
...pkg2,
12561272
private: true,
1257-
}));
1273+
});
12581274

12591275
instance.scanThirdParties();
12601276

0 commit comments

Comments
 (0)
Please sign in to comment.