Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download defaults #105

Open
eode opened this issue Jun 30, 2022 · 3 comments
Open

Download defaults #105

eode opened this issue Jun 30, 2022 · 3 comments

Comments

@eode
Copy link
Contributor

eode commented Jun 30, 2022

You may disagree, but I think that covering typical use cases by default would be good user experience.

Default to --aax or --aax-fallback

  • example
    • audible download --aax --title nemesis becomes audible download --title nemesis
  • in most cases, removes unecessary typing from the command

This covers the broadest and simplest usage of the program -- to get an audiobook.
The user can still get the other downloadables by specifying those formats explicitly, but this covers the basic use case without requiring additional input.

Use non-option trailing free text as an unspecified match

This should be mutually exclusive with any --title or --asin option. That is, you can either use --title and/or --asin, or you can use free text.

  • example (assumes prior change)
    • audible download --title "nemesis games" --title "foo fighters"
      • becomes audible download "nemesis games" "foo fighters"
    • audible download --asin B00Y1O1FYG
      • becomes audible download B00Y1O1FYG
    • audible download B00Y1O1FYG "foo fighters" should work
    • any other future selection criteria are included -- for example, if you added --series.

Don't disambiguate between selections that are unambiguous

  • If a given specification results in only one result, don't show selection dialog

Note: this should apply per-selector -- that is, if someone states audible download --title 'nemesis' --title fish, and only one book is found per selector, it should not disambiguate. This appears to fit the current behavior anyways, though.

Thanks for your time -- I hope these thoughts are useful. In any case, you've made a great tool that works well.

@eode
Copy link
Contributor Author

eode commented Jun 30, 2022

Note: I'm familiar with Python and would be happy to implement.

@mkb79
Copy link
Owner

mkb79 commented Jun 30, 2022

Default to --aax or --aax-fallback

This was one of my thoughts in the past. But I decided against it. Some users prioritize aax, some aaxc. What if a user wants to download a cover and forgets --cover? Then the app immediately downloads the aax.
But I could imagine an option in the config file where you can specify a default behavior. If none default is specified, it remains with the current behavior. How does that sound?

Use non-option trailing free text as an unspecified match

Yeah, click support arguments. So this is a good idea as an alternative to the --title or `--asin`` option!

Don't disambiguate between selections that are unambiguous

I also thought about it for a long time. My thought was what happens if the search does not bring the right result. In these cases, the app would also start downloading immediately. But I can also live well with your change proposal!

Note: I'm familiar with Python and would be happy to implement.

Help is very welcome. I am currently connected to my Python Goodreads API implementation.

@devnoname120
Copy link
Sponsor Contributor

Default to --aax or --aax-fallback

PSA for future visitors: --aax-fallback doesn't always properly fallback to downloading the AAXC file when the AAX file is missing. You can't rely on it to make sure that the AAXC file will be downloaded if AAX is missing!

See: #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants