Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangs on download error #135

Open
snowskeleton opened this issue Jan 4, 2023 · 13 comments
Open

Hangs on download error #135

snowskeleton opened this issue Jan 4, 2023 · 13 comments
Labels
wontfix This will not be worked on

Comments

@snowskeleton
Copy link
Contributor

I recently had an account error where a book was in my library but not downloadable (for unrelated reasons).

audible-cli didn't seem to handle this well. With the --all flag, it would download all legal targets, issuing errors and skipping existing files as appropriate, but then just hang indefinitely until interrupted.

Here's an abbreviated stack trace

$ audible download --all --aaxc
...
<other successful downloads>
...
error: The Wealth of Nations is not downloadable.
error: City of Light: The Traveler's Gate Trilogy, Volume 3 is not downloadable.                          
error: The Crimson Vault: The Traveler's Gate Trilogy, Volume 2 is not downloadable.
<hangs here>
^C
Aborted!
sys:1: RuntimeWarning: coroutine 'download_aaxc' was never awaited
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

Not a high priority issue, but I figured you'd like to have the info.

@mkb79
Copy link
Owner

mkb79 commented Jan 4, 2023

Hi. Thank you for this information. The code should not hang here, just skip the item. I will look on this.

FYI:
You don’t have the right to consume these titles offline. Maybe these are streamable only? These is the reason for the issue but not why it’s hang.

@snowskeleton
Copy link
Contributor Author

The reason for the error is that Audible removed the titles from their Plus catalog, so I no longer had rights to them. I was able to sort it out with amazon support thankfully.

@mkb79 mkb79 added the wontfix This will not be worked on label Feb 23, 2023
@philgoetz
Copy link

Is this related to the fact that audible-cli can't resume after a ctrl-z ?
I'm running audible-cli thru cygwin on a Windows 10 base, like this:

audible download -o downloads/aaxc/ --all --aax-fallback

I paused it with ctrl-z, but when I later tried to 'fg' it, it took over the foreground but never downloaded another file, nor terminated, nor printed anything to the terminal.

@mkb79
Copy link
Owner

mkb79 commented Mar 21, 2024

Do you have the same issue if you download an book with --aaxc instead of --aax-fallback

@philgoetz
Copy link

No, it resumes just fine from that.

@mkb79
Copy link
Owner

mkb79 commented Mar 22, 2024

@philgoetz
I'm think this issue have to do with #193.

@mkb79
Copy link
Owner

mkb79 commented Mar 22, 2024

@philgoetz
Can you try out the same with option --timeout 0? The new downloader class of audible-cli makes now a HEAD request to collect some information from the server. The response for this HEAD request will take 1 - 2 minutes for aax files. For aaxc files this take only some ms. Therefore the client will timeout without an exception. Why ever?!

@philgoetz
Copy link

@philgoetz Can you try out the same with option --timeout 0?

I did, and it resumed correctly!

@philgoetz
Copy link

I have another problem more-similar to that of the original poster: a crash on a file which is not downloadable

File /cygdrive/d/data/audio_/Audible/downloads/aaxc/How_to_See_Looking_Talking_and_Thinking_About_Art-AAX_22_64.aaxc already exists. Skip download.
error: Fundamental Principles of the Metaphysics of Morals is not downloadable.

Fundamental Principles etc. is listed on audible.com as a title available for purchase, but when viewed within my library, it says it is "Unavailable". After I click on 'Unavailable' for more info, a popup appears saying "Check that your Audible membership isn’t cancelled or paused. If it isn't, this title may not be available anymore."

I think this is a title which I added to my library when it was temporarily free, and which isn't free anymore.
There will be many such files in my library.

@mkb79
Copy link
Owner

mkb79 commented Mar 22, 2024

You can try to provide the --ignore-errors option.

@snowskeleton
Copy link
Contributor Author

Also @philgoetz you might have some luck reaching out to Audible support to have those titles permanently added to your library. I had "purchased" a couple free titles that stopped being free, and they added them to my account when I asked. YMMV.

@philgoetz
Copy link

You can try to provide the --ignore-errors option.

I removed all those titles, and provided --ignore-errors, and successfully downloaded everything.

@philgoetz
Copy link

philgoetz commented Mar 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants