Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DictOfItems type for configuration options #3242

Merged
merged 6 commits into from
Jun 6, 2023
Merged

Add DictOfItems type for configuration options #3242

merged 6 commits into from
Jun 6, 2023

Conversation

pawamoy
Copy link
Sponsor Contributor

@pawamoy pawamoy commented Jun 5, 2023 •
edited

As discussed in #3240.
Absolutely feel free to push to the branch directly.
I copied the tests for ListOfItems and adapted them.

@pawamoy pawamoy requested a review from oprypin June 5, 2023 15:42
oprypin
oprypin approved these changes Jun 5, 2023
View reviewed changes
mkdocs/config/config_options.py Outdated Show resolved Hide resolved
oprypin
oprypin approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pawamoy
Copy link
Sponsor Contributor Author

pawamoy commented Jun 6, 2023

Is there a hatch script to format the code?

@oprypin
Copy link
Contributor

oprypin commented Jun 6, 2023

Is there a hatch script to format the code?

hatch run style:format

@pawamoy
Copy link
Sponsor Contributor Author

pawamoy commented Jun 6, 2023 •
edited

Thanks, found it in pyproject but wasn't sure how to run 👍
Would be great to mention it in the contributing section of the docs. Will send a PR 🙂

@oprypin oprypin merged commit fdd30c0 into mkdocs:master Jun 6, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oprypin oprypin oprypin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pawamoy @oprypin